Merge pull request #159 from mvdnes/define-msrv

Define the crate's MSRV

.github/workflows/ci.yaml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        rust: [stable]
+        rust: [stable, 1.34.0]
 
     steps:
     - uses: actions/checkout@master

README.md

@@ -49,6 +49,17 @@ The features available are:
 
 All of these are enabled by default.
 
+MSRV
+----
+
+Our current Minimum Supported Rust Version is **1.34.0**. When adding features,
+we will follow these guidelines:
+
+- We will always support the latest four minor Rust versions. This gives you a 6
+  month window to upgrade your compiler.
+- Any change to the MSRV will be accompanied with a **minor** version bump
+   - While the crate is pre-1.0, this will be a change to the PATCH version.
+
 Examples
 --------
 

src/compression.rs

@@ -2,6 +2,7 @@
 
 use std::fmt;
 
+#[allow(deprecated)]
 /// Compression methods for the contents of a ZIP file.
 #[derive(Copy, Clone, PartialEq, Debug)]
 pub enum CompressionMethod {
@@ -28,13 +29,14 @@ impl CompressionMethod {
         note = "implementation details are being removed from the public API"
     )]
     pub fn from_u16(val: u16) -> CompressionMethod {
+        #[allow(deprecated)]
         match val {
             0 => CompressionMethod::Stored,
             #[cfg(feature = "deflate")]
             8 => CompressionMethod::Deflated,
             #[cfg(feature = "bzip2")]
             12 => CompressionMethod::Bzip2,
-            #[allow(deprecated)]
+
             v => CompressionMethod::Unsupported(v),
         }
     }
@@ -45,13 +47,13 @@ impl CompressionMethod {
         note = "implementation details are being removed from the public API"
     )]
     pub fn to_u16(self) -> u16 {
+        #[allow(deprecated)]
         match self {
             CompressionMethod::Stored => 0,
             #[cfg(feature = "deflate")]
             CompressionMethod::Deflated => 8,
             #[cfg(feature = "bzip2")]
             CompressionMethod::Bzip2 => 12,
-            #[allow(deprecated)]
             CompressionMethod::Unsupported(v) => v,
         }
     }

src/types.rs

@@ -1,6 +1,5 @@
 //! Types that specify what is contained in a ZIP.
 
-#[non_exhaustive]
 #[derive(Clone, Copy, Debug, PartialEq)]
 pub enum System {
     Dos = 0,

src/write.rs

@@ -397,20 +397,22 @@ impl<W: Write + io::Seek> GenericZipWriter<W> {
             }
         };
 
-        *self = match compression {
-            CompressionMethod::Stored => GenericZipWriter::Storer(bare),
-            #[cfg(feature = "deflate")]
-            CompressionMethod::Deflated => GenericZipWriter::Deflater(DeflateEncoder::new(
-                bare,
-                flate2::Compression::default(),
-            )),
-            #[cfg(feature = "bzip2")]
-            CompressionMethod::Bzip2 => {
-                GenericZipWriter::Bzip2(BzEncoder::new(bare, bzip2::Compression::Default))
-            }
+        *self = {
             #[allow(deprecated)]
-            CompressionMethod::Unsupported(..) => {
-                return Err(ZipError::UnsupportedArchive("Unsupported compression"))
+            match compression {
+                CompressionMethod::Stored => GenericZipWriter::Storer(bare),
+                #[cfg(feature = "deflate")]
+                CompressionMethod::Deflated => GenericZipWriter::Deflater(DeflateEncoder::new(
+                    bare,
+                    flate2::Compression::default(),
+                )),
+                #[cfg(feature = "bzip2")]
+                CompressionMethod::Bzip2 => {
+                    GenericZipWriter::Bzip2(BzEncoder::new(bare, bzip2::Compression::Default))
+                }
+                CompressionMethod::Unsupported(..) => {
+                    return Err(ZipError::UnsupportedArchive("Unsupported compression"))
+                }
             }
         };
 

tests/end_to_end.rs

@@ -39,7 +39,7 @@ fn read_zip_file(zip_file: &mut Cursor<Vec<u8>>) -> zip::result::ZipResult<Strin
     let mut archive = zip::ZipArchive::new(zip_file).unwrap();
 
     let expected_file_names = ["test/", "test/☃.txt", "test/lorem_ipsum.txt"];
-    let expected_file_names = HashSet::from_iter(expected_file_names.iter().copied());
+    let expected_file_names = HashSet::from_iter(expected_file_names.iter().map(|&v| v));
     let file_names = archive.file_names().collect::<HashSet<_>>();
     assert_eq!(file_names, expected_file_names);