review comments 1

benches/read_metadata.rs

@@ -1,7 +1,7 @@
 use bencher::{benchmark_group, benchmark_main};
 
 use std::fs;
-use std::io::{prelude::*, Cursor};
+use std::io::{self, prelude::*, Cursor};
 
 use bencher::Bencher;
 use getrandom::getrandom;
@@ -22,7 +22,7 @@ fn generate_random_archive(count_files: usize, file_size: usize) -> ZipResult<Ve
     for i in 0..count_files {
         let name = format!("file_deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef_{i}.dat");
         writer.start_file(name, options)?;
-        getrandom(&mut bytes).unwrap();
+        getrandom(&mut bytes).map_err(io::Error::from)?;
         writer.write_all(&bytes)?;
     }
 

src/compression.rs

@@ -110,7 +110,7 @@ impl CompressionMethod {
         }
     }
 
-    /// Converts an u16 to its corresponding CompressionMethod
+    /// Converts a u16 to its corresponding CompressionMethod
     #[deprecated(
         since = "0.5.7",
         note = "use a constant to construct a compression method"

src/read.rs

@@ -1034,9 +1034,9 @@ pub(crate) fn central_header_to_zip_file<R: Read + Seek>(
 
 #[inline]
 fn read_variable_length_byte_field<R: Read>(reader: &mut R, len: usize) -> io::Result<Box<[u8]>> {
-    let mut data = vec![0; len];
+    let mut data = vec![0; len].into_boxed_slice();
     reader.read_exact(&mut data)?;
-    Ok(data.into_boxed_slice())
+    Ok(data)
 }
 
 /// Parse a central directory entry to collect the information for the file.

src/spec.rs

@@ -282,7 +282,7 @@ impl Zip32CentralDirectoryEnd {
             ..
         } = Zip32CDEBlock::parse(reader)?;
 
-        let mut zip_file_comment = vec![0u8; zip_file_comment_length as usize];
+        let mut zip_file_comment = vec![0u8; zip_file_comment_length as usize].into_boxed_slice();
         reader.read_exact(&mut zip_file_comment)?;
 
         Ok(Zip32CentralDirectoryEnd {
@@ -292,7 +292,7 @@ impl Zip32CentralDirectoryEnd {
             number_of_files,
             central_directory_size,
             central_directory_offset,
-            zip_file_comment: zip_file_comment.into_boxed_slice(),
+            zip_file_comment,
         })
     }