DevComp/zip-rs-wasm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix stream benchmark

Browse source
This commit is contained in:
Danny McClanahan 2024-05-24 08:58:41 -04:00
parent a509efc28a
commit 8e5b157853
No known key found for this signature in database
GPG key ID: 6105C10F1A199CC7
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
benches/read_metadata.rs
View file

@ -95,21 +95,19 @@ fn parse_zip64_archive_with_comment(bench: &mut Bencher) {
bench.bytes = bytes.len() as u64; bench.bytes = bytes.len() as u64;
} }
#[allow(dead_code)]
fn parse_stream_archive(bench: &mut Bencher) { fn parse_stream_archive(bench: &mut Bencher) {
const STREAM_ZIP_ENTRIES: usize = 5; const STREAM_ZIP_ENTRIES: usize = 5;
const STREAM_FILE_SIZE: usize = 5; const STREAM_FILE_SIZE: usize = 5;
let bytes = generate_random_archive(STREAM_ZIP_ENTRIES, STREAM_FILE_SIZE).unwrap(); let bytes = generate_random_archive(STREAM_ZIP_ENTRIES, STREAM_FILE_SIZE).unwrap();
dbg!(&bytes);
/* Write to a temporary file path to incur some filesystem overhead from repeated reads */ /* Write to a temporary file path to incur some filesystem overhead from repeated reads */
let dir = TempDir::new("stream-bench").unwrap(); let dir = TempDir::new("stream-bench").unwrap();
let out = dir.path().join("bench-out.zip"); let out = dir.path().join("bench-out.zip");
fs::write(&out, &bytes).unwrap(); fs::write(&out, &bytes).unwrap();
let mut f = fs::File::open(out).unwrap();
bench.iter(|| loop { bench.iter(|| {
let mut f = fs::File::open(&out).unwrap();
while zip::read::read_zipfile_from_stream(&mut f) while zip::read::read_zipfile_from_stream(&mut f)
.unwrap() .unwrap()
.is_some() .is_some()
@ -123,7 +121,6 @@ benchmark_group!(
read_metadata, read_metadata,
parse_archive_with_comment, parse_archive_with_comment,
parse_zip64_archive_with_comment, parse_zip64_archive_with_comment,
/* FIXME: this currently errors */ parse_stream_archive,
/* parse_stream_archive */
); );
benchmark_main!(benches); benchmark_main!(benches);