DevComp/zip-rs-wasm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: deep_copy_file no longer allows overwriting an existing file, to match the behavior of shallow_copy_file

Browse source
This commit is contained in:
Chris Hennick 2024-06-17 15:17:03 -07:00
parent 8d78fd98f5
commit 6f120223b2
No known key found for this signature in database
GPG key ID: DA47AABA4961C509
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/write.rs
View file

@ -663,8 +663,8 @@ impl<A: Read + Write + Seek> ZipWriter<A> {
/// widely-compatible archive compared to [Self::shallow_copy_file]. Does not copy alignment.
pub fn deep_copy_file(&mut self, src_name: &str, dest_name: &str) -> ZipResult<()> {
self.finish_file()?;
if src_name == dest_name {
return Err(InvalidArchive("Trying to copy a file to itself"));
if src_name == dest_name || self.files.contains_key(dest_name) {
return Err(InvalidArchive("That file already exists"));
}
let write_position = self.inner.get_plain().stream_position()?;
let src_index = self.index_by_name(src_name)?;