0x5eal/luau-unzip
1
1
Fork 0
mirror of https://github.com/0x5eal/luau-unzip.git synced 2025-04-03 22:20:55 +01:00
Code Issues Projects Releases Packages Wiki Activity

fix: max comment size is 64 KB, not 64 KiB

Browse source 
This was caught in the new test case for max length comments, where the
comment would partially get cut off due us to using the wrong size units
in `ZipReader:findEocdPosition`.
This commit is contained in:
Erica Marigold 2025-02-23 19:20:07 +00:00
parent e70b3b8055
commit a5bb7166ad
Signed by: DevComp
SSH key fingerprint: SHA256:jD3oMT4WL3WHPJQbrjC3l5feNCnkv7ndW8nYaHX5wFw
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/init.luau
View file

@ -453,7 +453,7 @@ function ZipReader.findEocdPosition(self: ZipReader): number
local bufSize = buffer.len(self.data)
-- Start from the minimum possible position of EoCD (22 bytes from end)
local position = math.max(0, bufSize - (22 + 65535) --[[ max comment size: 64 KiB ]])
local position = math.max(0, bufSize - (22 + 65578) --[[ max comment size: 64 KB ]])
local searchBuf = buffer.create(BUFFER_SIZE)
while position < bufSize do