From a5bb7166ad38a7c79f0dc6784832363690f19283 Mon Sep 17 00:00:00 2001 From: Erica Marigold Date: Sun, 23 Feb 2025 19:20:07 +0000 Subject: [PATCH] fix: max comment size is 64 KB, not 64 KiB This was caught in the new test case for max length comments, where the comment would partially get cut off due us to using the wrong size units in `ZipReader:findEocdPosition`. --- lib/init.luau | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/init.luau b/lib/init.luau index 8f35935..2672206 100644 --- a/lib/init.luau +++ b/lib/init.luau @@ -453,7 +453,7 @@ function ZipReader.findEocdPosition(self: ZipReader): number local bufSize = buffer.len(self.data) -- Start from the minimum possible position of EoCD (22 bytes from end) - local position = math.max(0, bufSize - (22 + 65535) --[[ max comment size: 64 KiB ]]) + local position = math.max(0, bufSize - (22 + 65578) --[[ max comment size: 64 KB ]]) local searchBuf = buffer.create(BUFFER_SIZE) while position < bufSize do