pesde-pkg/pesde
1
1
Fork 0
mirror of https://github.com/pesde-pkg/pesde.git synced 2025-04-06 03:40:59 +01:00
Code Issues Projects Releases Packages Wiki Activity

refactor: allow publishing other packages on error

Browse source 
Previously, if a package failed to publish the
whole publishing process would halt. Then, if
a re-ran publishing got to an already published
package it'd error, which would require users to
manually publish the missing packages. This commit
fixes that by printing errors, but allowing other
members to still get published.
This commit is contained in:
daimond113 2025-02-16 11:32:16 +01:00
parent 9b70929e02
commit aa4f283e4c
No known key found for this signature in database
GPG key ID: 640DC95EC1190354
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/cli/commands/publish.rs
View file

@ -77,7 +77,6 @@ impl PublishCommand {
self, self,
project: &Project, project: &Project,
reqwest: reqwest::Client, reqwest: reqwest::Client,
is_root: bool,
refreshed_sources: &RefreshedSources, refreshed_sources: &RefreshedSources,
) -> anyhow::Result<()> { ) -> anyhow::Result<()> {
let mut manifest = project let mut manifest = project
@ -96,12 +95,10 @@ impl PublishCommand {
); );
if manifest.private { if manifest.private {
if !is_root { println!(
println!( "{}",
"{}", ERROR_STYLE.apply_to("package is private, refusing to publish")
ERROR_STYLE.apply_to("package is private, cannot publish") );
);
}
return Ok(()); return Ok(());
} }
@ -705,7 +702,7 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
let result = self let result = self
.clone() .clone()
.run_impl(&project, reqwest.clone(), true, &refreshed_sources) .run_impl(&project, reqwest.clone(), &refreshed_sources)
.await; .await;
if project.workspace_dir().is_some() { if project.workspace_dir().is_some() {
return result; return result;
@ -718,8 +715,9 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
let this = self.clone(); let this = self.clone();
let refreshed_sources = refreshed_sources.clone(); let refreshed_sources = refreshed_sources.clone();
async move { async move {
this.run_impl(&project, reqwest, false, &refreshed_sources) let res = this.run_impl(&project, reqwest, &refreshed_sources).await;
.await display_err(res, " occurred publishing workspace member");
Ok(())
} }
}) })
.await .await