From aa4f283e4cfed09afc50fb430f813ef18fe64b2e Mon Sep 17 00:00:00 2001 From: daimond113 Date: Sun, 16 Feb 2025 11:32:16 +0100 Subject: [PATCH] refactor: allow publishing other packages on error Previously, if a package failed to publish the whole publishing process would halt. Then, if a re-ran publishing got to an already published package it'd error, which would require users to manually publish the missing packages. This commit fixes that by printing errors, but allowing other members to still get published. --- src/cli/commands/publish.rs | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/cli/commands/publish.rs b/src/cli/commands/publish.rs index 407d790..ae48745 100644 --- a/src/cli/commands/publish.rs +++ b/src/cli/commands/publish.rs @@ -77,7 +77,6 @@ impl PublishCommand { self, project: &Project, reqwest: reqwest::Client, - is_root: bool, refreshed_sources: &RefreshedSources, ) -> anyhow::Result<()> { let mut manifest = project @@ -96,12 +95,10 @@ impl PublishCommand { ); if manifest.private { - if !is_root { - println!( - "{}", - ERROR_STYLE.apply_to("package is private, cannot publish") - ); - } + println!( + "{}", + ERROR_STYLE.apply_to("package is private, refusing to publish") + ); return Ok(()); } @@ -705,7 +702,7 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p let result = self .clone() - .run_impl(&project, reqwest.clone(), true, &refreshed_sources) + .run_impl(&project, reqwest.clone(), &refreshed_sources) .await; if project.workspace_dir().is_some() { return result; @@ -718,8 +715,9 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p let this = self.clone(); let refreshed_sources = refreshed_sources.clone(); async move { - this.run_impl(&project, reqwest, false, &refreshed_sources) - .await + let res = this.run_impl(&project, reqwest, &refreshed_sources).await; + display_err(res, " occurred publishing workspace member"); + Ok(()) } }) .await