mirror of
https://github.com/luau-lang/luau.git
synced 2025-08-26 11:27:08 +01:00
713ee2ff8b
# What's Changed?
We've been hard at work fixing bugs in the new type solver and getting
it ready to go!
## Native Codegen
* Specialized Luau Codegen instruction for fetching an import.
As a reminder, an import is an expression like `global.thing` and covers
stuff like libraries without fastcalls `coroutine.resume`) and atomic
extern libraries.
## New Type Solver
* Fix an issue that prevented eager generalization from working properly
with OO styled code.
* Avoid copying uninitialized memory in Luau attribute parsing
* Improve type inference of unsealed tables.
* This fixes https://github.com/luau-lang/luau/issues/1838
* and https://github.com/luau-lang/luau/issues/1859
* Infer potential singleton string keys in autocomplete when the
expected index type is a union type.
* Avoid creating cyclic types when reducing types of the form `t1 where
t1 = refine<T, t1, Y>`
* The type cloner now does the same thing for the new and old solvers.
* Properly infer polarity (aka variance) for divergent table properties.
(ie tables whose read type and write type are not the same)
* Crash fixes.
---------
Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com>
Co-authored-by: Varun Saini <61795485+vrn-sn@users.noreply.github.com>
Co-authored-by: Alexander Youngblood <ayoungblood@roblox.com>
Co-authored-by: Menarul Alam <malam@roblox.com>
Co-authored-by: Aviral Goel <agoel@roblox.com>
Co-authored-by: Vighnesh <vvijay@roblox.com>
Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
Co-authored-by: Ariel Weiss <aaronweiss@roblox.com>
52 lines
1.5 KiB
C++
52 lines
1.5 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
|
|
#include "Luau/Instantiation2.h"
|
|
|
|
#include "Fixture.h"
|
|
#include "ClassFixture.h"
|
|
#include "Luau/Type.h"
|
|
#include "ScopedFlags.h"
|
|
|
|
#include "doctest.h"
|
|
|
|
using namespace Luau;
|
|
|
|
TEST_SUITE_BEGIN("Instantiation2Test");
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "weird_cyclic_instantiation")
|
|
{
|
|
TypeArena arena;
|
|
Scope scope(getBuiltins()->anyTypePack);
|
|
|
|
TypeId genericT = arena.addType(GenericType{"T"});
|
|
|
|
TypeId idTy = arena.addType(FunctionType{
|
|
/* generics */ {genericT},
|
|
/* genericPacks */ {},
|
|
/* argTypes */ arena.addTypePack({genericT}),
|
|
/* retTypes */ arena.addTypePack({genericT})
|
|
});
|
|
|
|
DenseHashMap<TypeId, TypeId> genericSubstitutions{nullptr};
|
|
DenseHashMap<TypePackId, TypePackId> genericPackSubstitutions{nullptr};
|
|
|
|
TypeId freeTy = arena.freshType(getBuiltins(), &scope);
|
|
FreeType* ft = getMutable<FreeType>(freeTy);
|
|
REQUIRE(ft);
|
|
ft->lowerBound = idTy;
|
|
ft->upperBound = getBuiltins()->unknownType;
|
|
|
|
genericSubstitutions[genericT] = freeTy;
|
|
|
|
CHECK("<T>(T) -> T" == toString(idTy));
|
|
|
|
std::optional<TypeId> res = instantiate2(&arena, std::move(genericSubstitutions), std::move(genericPackSubstitutions), idTy);
|
|
|
|
// Substitutions should not mutate the original type!
|
|
CHECK("<T>(T) -> T" == toString(idTy));
|
|
|
|
REQUIRE(res);
|
|
CHECK("<T>(T) -> T" == toString(*res));
|
|
}
|
|
|
|
TEST_SUITE_END();
|