mirror of
https://github.com/luau-lang/luau.git
synced 2025-04-02 01:40:54 +01:00
Hello all! Another week, another Luau release! # Change to `lua_setuserdatametatable` This release fixes #1710: `lua_setuserdatametatable` is being changed so that it _only_ operates on the top of the stack: the `idx` parameter is being removed. Prior to this, `lua_setuserdatametable` would set the metatable of the value in the stack at `idx`, but _always_ pop the top of the stack. The old behavior is available in this release as `lua_setuserdatametatable_DEPRECATED`. # General This release exposes a generalized implementation of require-by-string's autocomplete logic. `FileResolver` can now be optionally constructed with a `RequireSuggester`, which provides an interface for converting a given module to a `RequireNode`. Consumers of this new API implement a `RequireNode` to define how modules are represented in their embedded context, and the new API manages the logic specific to require-by-string, including providing suggestions for require aliases. This enhancement moves toward integrating require-by-string's semantics into the language itself, rather than merely providing a specification for community members to implement themselves. # New Type Solver * Fixed a source of potential `Luau::follow detected a Type cycle` internal compiler exceptions when assigning a global to itself. * Fixed an issue whereby `*no-refine*` (a type which should not be visible at the end of type checking) was not being properly elided, causing inference of class-like tables to become unreadable / induce crashes in autocomplete. * Fixed a case of incomplete constraint solving when performing basic math in a loop # Fragment Autocomplete * Fixed several crashes related to not properly filling in scope information for the fragments * Fixed a source of memory corruption by isolating the return type of a fragment when it is type checked. * Improved performance by opting not to clone persistent types for the fragment (e.g.: built in types) # Internal Contributors Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com> Co-authored-by: Talha Pathan <tpathan@roblox.com> Co-authored-by: Varun Saini <vsaini@roblox.com> Co-authored-by: Vighnesh Vijay <vvijay@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com> --------- Co-authored-by: Varun Saini <61795485+vrn-sn@users.noreply.github.com> Co-authored-by: Alexander Youngblood <ayoungblood@roblox.com> Co-authored-by: Menarul Alam <malam@roblox.com> Co-authored-by: Aviral Goel <agoel@roblox.com> Co-authored-by: Vighnesh <vvijay@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com> Co-authored-by: Ariel Weiss <aaronweiss@roblox.com>
134 lines
3.4 KiB
C++
134 lines
3.4 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
#pragma once
|
|
|
|
#include <memory>
|
|
#include <optional>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
namespace Luau
|
|
{
|
|
|
|
class AstExpr;
|
|
|
|
using ModuleName = std::string;
|
|
|
|
struct SourceCode
|
|
{
|
|
enum Type
|
|
{
|
|
None,
|
|
Module,
|
|
Script,
|
|
Local
|
|
};
|
|
|
|
std::string source;
|
|
Type type;
|
|
};
|
|
|
|
struct ModuleInfo
|
|
{
|
|
ModuleName name;
|
|
bool optional = false;
|
|
};
|
|
|
|
struct RequireAlias
|
|
{
|
|
std::string alias; // Unprefixed alias name (no leading `@`).
|
|
std::vector<std::string> tags = {};
|
|
};
|
|
|
|
struct RequireNode
|
|
{
|
|
virtual ~RequireNode() {}
|
|
|
|
// Get the path component representing this node.
|
|
virtual std::string getPathComponent() const = 0;
|
|
|
|
// Get the displayed user-facing label for this node, defaults to getPathComponent()
|
|
virtual std::string getLabel() const
|
|
{
|
|
return getPathComponent();
|
|
}
|
|
|
|
// Get tags to attach to this node's RequireSuggestion (defaults to none).
|
|
virtual std::vector<std::string> getTags() const
|
|
{
|
|
return {};
|
|
}
|
|
|
|
// TODO: resolvePathToNode() can ultimately be replaced with a call into
|
|
// require-by-string's path resolution algorithm. This will first require
|
|
// generalizing that algorithm to work with a virtual file system.
|
|
virtual std::unique_ptr<RequireNode> resolvePathToNode(const std::string& path) const = 0;
|
|
|
|
// Get children of this node, if any (if this node represents a directory).
|
|
virtual std::vector<std::unique_ptr<RequireNode>> getChildren() const = 0;
|
|
|
|
// A list of the aliases available to this node.
|
|
virtual std::vector<RequireAlias> getAvailableAliases() const = 0;
|
|
};
|
|
|
|
struct RequireSuggestion
|
|
{
|
|
std::string label;
|
|
std::string fullPath;
|
|
std::vector<std::string> tags;
|
|
};
|
|
using RequireSuggestions = std::vector<RequireSuggestion>;
|
|
|
|
struct RequireSuggester
|
|
{
|
|
virtual ~RequireSuggester() {}
|
|
std::optional<RequireSuggestions> getRequireSuggestions(const ModuleName& requirer, const std::optional<std::string>& pathString) const;
|
|
|
|
protected:
|
|
virtual std::unique_ptr<RequireNode> getNode(const ModuleName& name) const = 0;
|
|
|
|
private:
|
|
std::optional<RequireSuggestions> getRequireSuggestionsImpl(const ModuleName& requirer, const std::optional<std::string>& path) const;
|
|
};
|
|
|
|
struct FileResolver
|
|
{
|
|
FileResolver() = default;
|
|
FileResolver(std::shared_ptr<RequireSuggester> requireSuggester)
|
|
: requireSuggester(std::move(requireSuggester))
|
|
{
|
|
}
|
|
|
|
virtual ~FileResolver() {}
|
|
|
|
virtual std::optional<SourceCode> readSource(const ModuleName& name) = 0;
|
|
|
|
virtual std::optional<ModuleInfo> resolveModule(const ModuleInfo* context, AstExpr* expr)
|
|
{
|
|
return std::nullopt;
|
|
}
|
|
|
|
virtual std::string getHumanReadableModuleName(const ModuleName& name) const
|
|
{
|
|
return name;
|
|
}
|
|
|
|
virtual std::optional<std::string> getEnvironmentForModule(const ModuleName& name) const
|
|
{
|
|
return std::nullopt;
|
|
}
|
|
|
|
// Make non-virtual when removing FFlagLuauImproveRequireByStringAutocomplete.
|
|
virtual std::optional<RequireSuggestions> getRequireSuggestions(const ModuleName& requirer, const std::optional<std::string>& pathString) const;
|
|
|
|
std::shared_ptr<RequireSuggester> requireSuggester;
|
|
};
|
|
|
|
struct NullFileResolver : FileResolver
|
|
{
|
|
std::optional<SourceCode> readSource(const ModuleName& name) override
|
|
{
|
|
return std::nullopt;
|
|
}
|
|
};
|
|
|
|
} // namespace Luau
|