mirror of
https://github.com/luau-lang/luau.git
synced 2024-12-13 21:40:43 +00:00
02241b6d24
In this update, we continue to improve the overall stability of the new type solver. We're also shipping some early bits of two new features, one of the language and one of the analysis API: user-defined type functions and an incremental typechecking API. If you use the new solver and want to use all new fixes included in this release, you have to reference an additional Luau flag: ```c++ LUAU_DYNAMIC_FASTINT(LuauTypeSolverRelease) ``` And set its value to `645`: ```c++ DFInt::LuauTypeSolverRelease.value = 645; // Or a higher value for future updates ``` ## New Solver * Fix a crash where scopes are incorrectly accessed cross-module after they've been deallocated by appropriately zeroing out associated scope pointers for free types, generic types, table types, etc. * Fix a crash where we were incorrectly caching results for bound types in generalization. * Eliminated some unnecessary intermediate allocations in the constraint solver and type function infrastructure. * Built some initial groundwork for an incremental typecheck API for use by language servers. * Built an initial technical preview for [user-defined type functions](https://rfcs.luau-lang.org/user-defined-type-functions.html), more work still to come (including calling type functions from other type functions), but adventurous folks wanting to experiment with it can try it out by enabling `FFlag::LuauUserDefinedTypeFunctionsSyntax` and `FFlag::LuauUserDefinedTypeFunction` in their local environment. Special thanks to @joonyoo181 who built up all the initial infrastructure for this during his internship! ## Miscellaneous changes * Fix a compilation error on Ubuntu (fixes #1437) --- Internal Contributors: Co-authored-by: Aaron Weiss <aaronweiss@roblox.com> Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com> Co-authored-by: Jeremy Yoo <jyoo@roblox.com> Co-authored-by: Vighnesh Vijay <vvijay@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com> --------- Co-authored-by: Alexander McCord <amccord@roblox.com> Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Vighnesh <vvijay@roblox.com> Co-authored-by: Aviral Goel <agoel@roblox.com> Co-authored-by: David Cope <dcope@roblox.com> Co-authored-by: Lily Brown <lbrown@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com> Co-authored-by: Junseo Yoo <jyoo@roblox.com>
278 lines
6.6 KiB
C++
278 lines
6.6 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
#include "Luau/TimeTrace.h"
|
|
|
|
#include "Luau/StringUtils.h"
|
|
|
|
#include <algorithm>
|
|
#include <mutex>
|
|
#include <string>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#ifdef _WIN32
|
|
#ifndef WIN32_LEAN_AND_MEAN
|
|
#define WIN32_LEAN_AND_MEAN
|
|
#endif
|
|
#ifndef NOMINMAX
|
|
#define NOMINMAX
|
|
#endif
|
|
#include <windows.h>
|
|
#endif
|
|
|
|
#ifdef __APPLE__
|
|
#include <mach/mach.h>
|
|
#include <mach/mach_time.h>
|
|
#endif
|
|
|
|
#include <time.h>
|
|
|
|
LUAU_FASTFLAGVARIABLE(DebugLuauTimeTracing, false)
|
|
namespace Luau
|
|
{
|
|
namespace TimeTrace
|
|
{
|
|
static double getClockPeriod()
|
|
{
|
|
#if defined(_WIN32)
|
|
LARGE_INTEGER result = {};
|
|
QueryPerformanceFrequency(&result);
|
|
return 1.0 / double(result.QuadPart);
|
|
#elif defined(__APPLE__)
|
|
mach_timebase_info_data_t result = {};
|
|
mach_timebase_info(&result);
|
|
return double(result.numer) / double(result.denom) * 1e-9;
|
|
#elif defined(__linux__) || defined(__FreeBSD__)
|
|
return 1e-9;
|
|
#else
|
|
return 1.0 / double(CLOCKS_PER_SEC);
|
|
#endif
|
|
}
|
|
|
|
static double getClockTimestamp()
|
|
{
|
|
#if defined(_WIN32)
|
|
LARGE_INTEGER result = {};
|
|
QueryPerformanceCounter(&result);
|
|
return double(result.QuadPart);
|
|
#elif defined(__APPLE__)
|
|
return double(mach_absolute_time());
|
|
#elif defined(__linux__) || defined(__FreeBSD__)
|
|
timespec now;
|
|
clock_gettime(CLOCK_MONOTONIC, &now);
|
|
return now.tv_sec * 1e9 + now.tv_nsec;
|
|
#else
|
|
return double(clock());
|
|
#endif
|
|
}
|
|
|
|
double getClock()
|
|
{
|
|
static double period = getClockPeriod();
|
|
static double start = getClockTimestamp();
|
|
|
|
return (getClockTimestamp() - start) * period;
|
|
}
|
|
|
|
uint32_t getClockMicroseconds()
|
|
{
|
|
static double period = getClockPeriod() * 1e6;
|
|
static double start = getClockTimestamp();
|
|
|
|
return uint32_t((getClockTimestamp() - start) * period);
|
|
}
|
|
} // namespace TimeTrace
|
|
} // namespace Luau
|
|
|
|
#if defined(LUAU_ENABLE_TIME_TRACE)
|
|
|
|
namespace Luau
|
|
{
|
|
namespace TimeTrace
|
|
{
|
|
struct GlobalContext
|
|
{
|
|
~GlobalContext()
|
|
{
|
|
if (traceFile)
|
|
fclose(traceFile);
|
|
}
|
|
|
|
std::mutex mutex;
|
|
std::vector<ThreadContext*> threads;
|
|
uint32_t nextThreadId = 0;
|
|
std::vector<Token> tokens;
|
|
FILE* traceFile = nullptr;
|
|
|
|
private:
|
|
friend std::shared_ptr<GlobalContext> getGlobalContext();
|
|
GlobalContext() = default;
|
|
};
|
|
|
|
std::shared_ptr<GlobalContext> getGlobalContext()
|
|
{
|
|
static std::shared_ptr<GlobalContext> context = std::shared_ptr<GlobalContext>{new GlobalContext};
|
|
return context;
|
|
}
|
|
|
|
uint16_t createToken(GlobalContext& context, const char* name, const char* category)
|
|
{
|
|
std::scoped_lock lock(context.mutex);
|
|
|
|
LUAU_ASSERT(context.tokens.size() < 64 * 1024);
|
|
|
|
context.tokens.push_back({name, category});
|
|
return uint16_t(context.tokens.size() - 1);
|
|
}
|
|
|
|
uint32_t createThread(GlobalContext& context, ThreadContext* threadContext)
|
|
{
|
|
std::scoped_lock lock(context.mutex);
|
|
|
|
context.threads.push_back(threadContext);
|
|
|
|
return ++context.nextThreadId;
|
|
}
|
|
|
|
void releaseThread(GlobalContext& context, ThreadContext* threadContext)
|
|
{
|
|
std::scoped_lock lock(context.mutex);
|
|
|
|
if (auto it = std::find(context.threads.begin(), context.threads.end(), threadContext); it != context.threads.end())
|
|
context.threads.erase(it);
|
|
}
|
|
|
|
void flushEvents(GlobalContext& context, uint32_t threadId, const std::vector<Event>& events, const std::vector<char>& data)
|
|
{
|
|
std::scoped_lock lock(context.mutex);
|
|
|
|
if (!context.traceFile)
|
|
{
|
|
context.traceFile = fopen("trace.json", "w");
|
|
|
|
if (!context.traceFile)
|
|
return;
|
|
|
|
fprintf(context.traceFile, "[\n");
|
|
}
|
|
|
|
std::string temp;
|
|
const unsigned tempReserve = 64 * 1024;
|
|
temp.reserve(tempReserve);
|
|
|
|
const char* rawData = data.data();
|
|
|
|
// Formatting state
|
|
bool unfinishedEnter = false;
|
|
bool unfinishedArgs = false;
|
|
|
|
for (const Event& ev : events)
|
|
{
|
|
switch (ev.type)
|
|
{
|
|
case EventType::Enter:
|
|
{
|
|
if (unfinishedArgs)
|
|
{
|
|
formatAppend(temp, "}");
|
|
unfinishedArgs = false;
|
|
}
|
|
|
|
if (unfinishedEnter)
|
|
{
|
|
formatAppend(temp, "},\n");
|
|
unfinishedEnter = false;
|
|
}
|
|
|
|
Token& token = context.tokens[ev.token];
|
|
|
|
formatAppend(
|
|
temp,
|
|
R"({"name": "%s", "cat": "%s", "ph": "B", "ts": %u, "pid": 0, "tid": %u)",
|
|
token.name,
|
|
token.category,
|
|
ev.data.microsec,
|
|
threadId
|
|
);
|
|
unfinishedEnter = true;
|
|
}
|
|
break;
|
|
case EventType::Leave:
|
|
if (unfinishedArgs)
|
|
{
|
|
formatAppend(temp, "}");
|
|
unfinishedArgs = false;
|
|
}
|
|
if (unfinishedEnter)
|
|
{
|
|
formatAppend(temp, "},\n");
|
|
unfinishedEnter = false;
|
|
}
|
|
|
|
formatAppend(
|
|
temp,
|
|
R"({"ph": "E", "ts": %u, "pid": 0, "tid": %u},)"
|
|
"\n",
|
|
ev.data.microsec,
|
|
threadId
|
|
);
|
|
break;
|
|
case EventType::ArgName:
|
|
LUAU_ASSERT(unfinishedEnter);
|
|
|
|
if (!unfinishedArgs)
|
|
{
|
|
formatAppend(temp, R"(, "args": { "%s": )", rawData + ev.data.dataPos);
|
|
unfinishedArgs = true;
|
|
}
|
|
else
|
|
{
|
|
formatAppend(temp, R"(, "%s": )", rawData + ev.data.dataPos);
|
|
}
|
|
break;
|
|
case EventType::ArgValue:
|
|
LUAU_ASSERT(unfinishedArgs);
|
|
formatAppend(temp, R"("%s")", rawData + ev.data.dataPos);
|
|
break;
|
|
}
|
|
|
|
// Don't want to hit the string capacity and reallocate
|
|
if (temp.size() > tempReserve - 1024)
|
|
{
|
|
fwrite(temp.data(), 1, temp.size(), context.traceFile);
|
|
temp.clear();
|
|
}
|
|
}
|
|
|
|
if (unfinishedArgs)
|
|
{
|
|
formatAppend(temp, "}");
|
|
unfinishedArgs = false;
|
|
}
|
|
if (unfinishedEnter)
|
|
{
|
|
formatAppend(temp, "},\n");
|
|
unfinishedEnter = false;
|
|
}
|
|
|
|
fwrite(temp.data(), 1, temp.size(), context.traceFile);
|
|
fflush(context.traceFile);
|
|
}
|
|
|
|
ThreadContext& getThreadContext()
|
|
{
|
|
// Check custom provider that which might implement a custom TLS
|
|
if (auto provider = threadContextProvider())
|
|
return provider();
|
|
|
|
thread_local ThreadContext context;
|
|
return context;
|
|
}
|
|
|
|
uint16_t createScopeData(const char* name, const char* category)
|
|
{
|
|
return createToken(*Luau::TimeTrace::getGlobalContext(), name, category);
|
|
}
|
|
} // namespace TimeTrace
|
|
} // namespace Luau
|
|
|
|
#endif
|