mirror of
https://github.com/luau-lang/luau.git
synced 2024-12-12 21:10:37 +00:00
68bd1b2349
# What's changed? * Improved the actual message for the type errors for `cannot call non-function` when attempting to call a union of functions/callable tables. The error now correctly explains the issue is an inability to determine the return type of the call in this situation. * Resolve an issue where tables and metatables were not correctly being cloned during instantiation (fixes #1176). * Refactor `luaM_getnextgcopage` to `luaM_getnextpage` (generally removing `gco` prefix where appropriate). * Optimize `table.move` between tables for large ranges of elements. * Reformat a bunch of code automatically using `clang-format`. ### New Type Solver * Clean up minimally-used or unused constraints in the constraint solver (`InstantiationConstraint`, `SetOpConstraint`, `SingletonOrTopTypeConstraint`). * Add a builtin `singleton` type family to replace `SingletonOrTopTypeConstraint` when inferring refinements. * Fixed a crash involving type path reasoning by recording when type family reduction has taken place in the path. * Improved constraint ordering by blocking on unreduced types families that are not yet proven uninhabitable. * Improved the handling of `SetIndexerConstraints` for both better inference quality and to resolve crashes. * Fix a crash when normalizing cyclic unions of intersections. * Fix a crash when normalizing an intersection with the negation of `unknown`. * Fix a number of crashes caused by missing `follow` calls on `TypeId`s. * Changed type family reduction to correctly use a semantic notion of uninhabited types, rather than checking for `never` types specifically. * Refactor the `union` and `intersect` type families to be variadic. ### Native Code Generation * Improve translation for userdata key get/set and userdata/vector namecall. * Provide `[top level]` and `[anonymous]` as function names to `FunctionStats` as appropriate when no function name is available. * Disable unwind support on Android platforms since it is unsupported. * --- ### Internal Contributors Co-authored-by: Aaron Weiss <aaronweiss@roblox.com> Co-authored-by: Alexander McCord <amccord@roblox.com> Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Aviral Goel <agoel@roblox.com> Co-authored-by: Vighnesh Vijay <vvijay@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com> --------- Co-authored-by: Alexander McCord <amccord@roblox.com> Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Vighnesh <vvijay@roblox.com> Co-authored-by: Aviral Goel <agoel@roblox.com> Co-authored-by: David Cope <dcope@roblox.com> Co-authored-by: Lily Brown <lbrown@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
51 lines
1.6 KiB
C++
51 lines
1.6 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
|
|
#include "Luau/Instantiation2.h"
|
|
|
|
#include "Fixture.h"
|
|
#include "ClassFixture.h"
|
|
#include "ScopedFlags.h"
|
|
|
|
#include "doctest.h"
|
|
|
|
using namespace Luau;
|
|
|
|
TEST_SUITE_BEGIN("Instantiation2Test");
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "weird_cyclic_instantiation")
|
|
{
|
|
TypeArena arena;
|
|
Scope scope(builtinTypes->anyTypePack);
|
|
|
|
TypeId genericT = arena.addType(GenericType{"T"});
|
|
|
|
TypeId idTy = arena.addType(FunctionType{/* generics */ {genericT},
|
|
/* genericPacks */ {},
|
|
/* argTypes */ arena.addTypePack({genericT}),
|
|
/* retTypes */ arena.addTypePack({genericT})});
|
|
|
|
DenseHashMap<TypeId, TypeId> genericSubstitutions{nullptr};
|
|
DenseHashMap<TypePackId, TypePackId> genericPackSubstitutions{nullptr};
|
|
|
|
TypeId freeTy = arena.freshType(&scope);
|
|
FreeType* ft = getMutable<FreeType>(freeTy);
|
|
REQUIRE(ft);
|
|
ft->lowerBound = idTy;
|
|
ft->upperBound = builtinTypes->unknownType;
|
|
|
|
genericSubstitutions[genericT] = freeTy;
|
|
|
|
CHECK("<T>(T) -> T" == toString(idTy));
|
|
|
|
std::optional<TypeId> res = instantiate2(&arena, std::move(genericSubstitutions), std::move(genericPackSubstitutions), idTy);
|
|
|
|
// Substitutions should not mutate the original type!
|
|
CHECK("<T>(T) -> T" == toString(idTy));
|
|
|
|
// Weird looking because we haven't properly clipped the generic from the
|
|
// function type, but this is what we asked for.
|
|
REQUIRE(res);
|
|
CHECK("<<T>(T) -> T>(<T>(T) -> T) -> <T>(T) -> T" == toString(*res));
|
|
}
|
|
|
|
TEST_SUITE_END();
|