mirror of
https://github.com/luau-lang/luau.git
synced 2025-05-04 10:33:46 +01:00
We have lots of new changes for you! # What's Changed ## General - We updated Luau's license year to 2025! - We fixed a bug where large amounts of errors were being printed when deep intersections of unions error. ## Require-by-String This release introduces the `Luau.Require` library, which exposes the runtime semantics of require-by-string, including support for the new `@self` alias described in [this RFC](https://github.com/luau-lang/rfcs/pull/109). The library operates on a virtualized filesystem, allowing consumers to specify navigation rules without assuming a filesystem context. Documentation in `Require.h` explains how to enable the library, and the `setupState` function in Repl.cpp demonstrates how we've integrated it into the luau CLI tool. Note that the interface in `Require.h` is written in C, which enables any application written in a language with a C foreign-function interface to link against this library and enable require-by-string. This makes it straightforward for any application embedding Luau to support require-by-string, provided that it defines or operates within an environment resembling a virtual filesystem. The core navigation semantics of require-by-string have additionally been pulled into the `Luau.RequireNavigator` library. While `Luau.Require` internally depends on `Luau.RequireNavigator`, the latter does not depend on the Luau VM. This library provides an interface for inspecting require-by-string's navigation behavior and therefore serves as a useful dependency for static tooling. Documentation for `Luau.RequireNavigator` is available in `RequireNavigator.h`. ## Autocomplete - We fixed a memory leak in fragment autocomplete! ## New Solver And Old Solver - We've found a infinite iteration error over a type pack. We added a way to detect this error and throw an `InternalCompileError` instead. - We fix `table.freeze` not accounting for the first argument not getting type stated. We fall back to regular inference instead. - We fix a crash in the old solver with `length_error`. - We fix a crash in the new solver stemming from generalization reentrancy. Now we correctly generalize interior free types that do not appear in a function signature. - We fix a nil refinement. (Fixes https://github.com/luau-lang/luau/issues/1687 and https://github.com/luau-lang/luau/issues/1451) ### Internal Contributors Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com> Co-authored-by: Talha Pathan <tpathan@roblox.com> Co-authored-by: Varun Saini <vsaini@roblox.com> Co-authored-by: Vighnesh Vijay <vvijay@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com> Full Changelog: https://github.com/luau-lang/luau/compare/0.668...0.669 --------- Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com> Co-authored-by: Varun Saini <61795485+vrn-sn@users.noreply.github.com> Co-authored-by: Alexander Youngblood <ayoungblood@roblox.com> Co-authored-by: Aviral Goel <agoel@roblox.com> Co-authored-by: Vighnesh <vvijay@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com> Co-authored-by: Ariel Weiss <aaronweiss@roblox.com>
146 lines
4.1 KiB
C++
146 lines
4.1 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
|
|
#include "RequireImpl.h"
|
|
|
|
#include "Navigation.h"
|
|
|
|
#include "Luau/RequireNavigator.h"
|
|
#include "Luau/Require.h"
|
|
|
|
#include "lua.h"
|
|
#include "lualib.h"
|
|
|
|
namespace Luau::Require
|
|
{
|
|
|
|
static const char* cacheTableKey = "_MODULES";
|
|
|
|
struct ResolvedRequire
|
|
{
|
|
enum class Status
|
|
{
|
|
Cached,
|
|
ModuleRead,
|
|
ErrorReported
|
|
};
|
|
|
|
Status status;
|
|
std::string contents;
|
|
std::string chunkname;
|
|
std::string cacheKey;
|
|
};
|
|
|
|
static bool isCached(lua_State* L, const std::string& key)
|
|
{
|
|
luaL_findtable(L, LUA_REGISTRYINDEX, cacheTableKey, 1);
|
|
lua_getfield(L, -1, key.c_str());
|
|
bool cached = !lua_isnil(L, -1);
|
|
lua_pop(L, 2);
|
|
|
|
return cached;
|
|
}
|
|
|
|
static ResolvedRequire resolveRequire(luarequire_Configuration* lrc, lua_State* L, void* ctx, std::string path)
|
|
{
|
|
lua_Debug ar;
|
|
lua_getinfo(L, 1, "s", &ar);
|
|
|
|
if (!lrc->is_require_allowed(L, ctx, ar.source))
|
|
luaL_error(L, "require is not supported in this context");
|
|
|
|
RuntimeNavigationContext navigationContext{lrc, L, ctx, ar.source};
|
|
RuntimeErrorHandler errorHandler{L}; // Errors reported directly to lua_State.
|
|
|
|
Navigator navigator(navigationContext, errorHandler);
|
|
|
|
// Updates navigationContext while navigating through the given path.
|
|
Navigator::Status status = navigator.navigate(std::move(path));
|
|
if (status == Navigator::Status::ErrorReported)
|
|
return {ResolvedRequire::Status::ErrorReported};
|
|
|
|
if (!navigationContext.isModulePresent())
|
|
{
|
|
luaL_errorL(L, "no module present at resolved path");
|
|
return ResolvedRequire{ResolvedRequire::Status::ErrorReported};
|
|
}
|
|
|
|
std::optional<std::string> cacheKey = navigationContext.getCacheKey();
|
|
if (!cacheKey)
|
|
{
|
|
errorHandler.reportError("could not get cache key for module");
|
|
return ResolvedRequire{ResolvedRequire::Status::ErrorReported};
|
|
}
|
|
|
|
if (isCached(L, *cacheKey))
|
|
{
|
|
// Put cached result on top of stack before returning.
|
|
lua_getfield(L, LUA_REGISTRYINDEX, cacheTableKey);
|
|
lua_getfield(L, -1, cacheKey->c_str());
|
|
lua_remove(L, -2);
|
|
|
|
return ResolvedRequire{ResolvedRequire::Status::Cached};
|
|
}
|
|
|
|
std::optional<std::string> chunkname = navigationContext.getChunkname();
|
|
if (!chunkname)
|
|
{
|
|
errorHandler.reportError("could not get chunkname for module");
|
|
return ResolvedRequire{ResolvedRequire::Status::ErrorReported};
|
|
}
|
|
|
|
std::optional<std::string> contents = navigationContext.getContents();
|
|
if (!contents)
|
|
{
|
|
errorHandler.reportError("could not get contents for module");
|
|
return ResolvedRequire{ResolvedRequire::Status::ErrorReported};
|
|
}
|
|
|
|
return ResolvedRequire{
|
|
ResolvedRequire::Status::ModuleRead,
|
|
std::move(*contents),
|
|
std::move(*chunkname),
|
|
std::move(*cacheKey),
|
|
};
|
|
}
|
|
|
|
int lua_require(lua_State* L)
|
|
{
|
|
luarequire_Configuration* lrc = static_cast<luarequire_Configuration*>(lua_touserdata(L, lua_upvalueindex(1)));
|
|
if (!lrc)
|
|
luaL_error(L, "unable to find require configuration");
|
|
|
|
void* ctx = lua_tolightuserdata(L, lua_upvalueindex(2));
|
|
|
|
const char* path = luaL_checkstring(L, 1);
|
|
|
|
ResolvedRequire resolvedRequire = resolveRequire(lrc, L, ctx, path);
|
|
if (resolvedRequire.status == ResolvedRequire::Status::Cached)
|
|
return 1;
|
|
|
|
int numResults = lrc->load(L, ctx, resolvedRequire.chunkname.c_str(), resolvedRequire.contents.c_str());
|
|
if (numResults > 1)
|
|
luaL_error(L, "module must return a single value");
|
|
|
|
// Cache the result
|
|
if (numResults == 1)
|
|
{
|
|
// Initial stack state
|
|
// (-1) result
|
|
|
|
lua_getfield(L, LUA_REGISTRYINDEX, cacheTableKey);
|
|
// (-2) result, (-1) cache table
|
|
|
|
lua_pushvalue(L, -2);
|
|
// (-3) result, (-2) cache table, (-1) result
|
|
|
|
lua_setfield(L, -2, resolvedRequire.cacheKey.c_str());
|
|
// (-2) result, (-1) cache table
|
|
|
|
lua_pop(L, 1);
|
|
// (-1) result
|
|
}
|
|
|
|
return numResults;
|
|
}
|
|
|
|
} // namespace Luau::Require
|