mirror of
https://github.com/luau-lang/luau.git
synced 2024-12-13 13:30:40 +00:00
c2ba1058c3
# What's changed? - Record the location of properties for table types (closes #802) - Implement stricter UTF-8 validations as per the RFC (https://github.com/luau-lang/rfcs/pull/1) - Implement `buffer` as a new type in both the old and new solvers. - Changed errors produced by some `buffer` builtins to be a bit more generic to avoid platform-dependent error messages. - Fixed a bug where `Unifier` would copy some persistent types, tripping some internal assertions. - Type checking rules on relational operators is now a little bit more lax. - Improve dead code elimination for some `if` statements with complex always-false conditions ## New type solver - Dataflow analysis now generates phi nodes on exit of branches. - Dataflow analysis avoids producing a new definition for locals or properties that are not owned by that loop. - If a function parameter has been constrained to `never`, report errors at all uses of that parameter within that function. - Switch to using the new `Luau::Set` to replace `std::unordered_set` to alleviate some poor allocation characteristics which was negatively affecting overall performance. - Subtyping can now report many failing reasons instead of just the first one that we happened to find during the test. - Subtyping now also report reasons for type pack mismatches. - When visiting `if` statements or expressions, the resulting context are the common terms in both branches. ## Native codegen - Implement support for `buffer` builtins to its IR for x64 and A64. - Optimized `table.insert` by not inserting a table barrier if it is fastcalled with a constant. ## Internal Contributors Co-authored-by: Aaron Weiss <aaronweiss@roblox.com> Co-authored-by: Alexander McCord <amccord@roblox.com> Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Arseny Kapoulkine <arseny@roblox.com> Co-authored-by: Aviral Goel <agoel@roblox.com> Co-authored-by: Lily Brown <lbrown@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
277 lines
6.7 KiB
C++
277 lines
6.7 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
#include "Fixture.h"
|
|
|
|
#include "doctest.h"
|
|
|
|
LUAU_FASTFLAG(DebugLuauDeferredConstraintResolution)
|
|
|
|
using namespace Luau;
|
|
|
|
namespace
|
|
{
|
|
struct TypeStateFixture : BuiltinsFixture
|
|
{
|
|
ScopedFastFlag dcr{"DebugLuauDeferredConstraintResolution", true};
|
|
};
|
|
}
|
|
|
|
TEST_SUITE_BEGIN("TypeStatesTest");
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "initialize_x_of_type_string_or_nil_with_nil")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x: string? = nil
|
|
local a = x
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("nil" == toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "extraneous_lvalues_are_populated_with_nil")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local function f(): (string, number)
|
|
return "hello", 5
|
|
end
|
|
|
|
local x, y, z = f()
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
CHECK("Function only returns 2 values, but 3 are required here" == toString(result.errors[0]));
|
|
CHECK("string" == toString(requireType("x")));
|
|
CHECK("number" == toString(requireType("y")));
|
|
CHECK("nil" == toString(requireType("z")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "assign_different_values_to_x")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x: string? = nil
|
|
local a = x
|
|
x = "hello!"
|
|
local b = x
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("nil" == toString(requireType("a")));
|
|
CHECK("string" == toString(requireType("b")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "parameter_x_was_constrained_by_two_types")
|
|
{
|
|
// Parameter `x` has a fresh type `'x` bounded by `never` and `unknown`.
|
|
// The first use of `x` constrains `x`'s upper bound by `string | number`.
|
|
// The second use of `x`, aliased by `y`, constrains `x`'s upper bound by `string?`.
|
|
// This results in `'x <: (string | number) & (string?)`.
|
|
// The principal type of the upper bound is `string`.
|
|
CheckResult result = check(R"(
|
|
local function f(x): string?
|
|
local y: string | number = x
|
|
return y
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("(string) -> string?" == toString(requireType("f")));
|
|
}
|
|
|
|
#if 0
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "local_that_will_be_assigned_later")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x: string
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "refine_a_local_and_then_assign_it")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
if typeof(x) == "string" then
|
|
x = nil
|
|
end
|
|
|
|
local y: nil = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "assign_a_local_and_then_refine_it")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
x = nil
|
|
|
|
if typeof(x) == "string" then
|
|
local y: typeof(x) = "hello"
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
CHECK("Type 'string' could not be converted into 'never'" == toString(result.errors[0]));
|
|
}
|
|
#endif
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "recursive_local_function")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local function f(x)
|
|
f(5)
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "recursive_function")
|
|
{
|
|
CheckResult result = check(R"(
|
|
function f(x)
|
|
f(5)
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "compound_assignment")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x = 5
|
|
x += 7
|
|
|
|
local a = x
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "assignment_identity")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x = 5
|
|
x = x
|
|
|
|
local a = x
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("number" == toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "assignment_swap")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x, y = 5, "hello"
|
|
x, y = y, x
|
|
|
|
local a, b = x, y
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("string" == toString(requireType("a")));
|
|
CHECK("number" == toString(requireType("b")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "parameter_x_was_constrained_by_two_types")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local function f(x): number?
|
|
local y: string? = nil -- 'y <: string?
|
|
y = x -- 'y ~ 'x
|
|
return y -- 'y <: number?
|
|
|
|
-- We therefore infer 'y <: (string | nil) & (number | nil)
|
|
-- or 'y <: nil
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("(nil) -> number?" == toString(requireType("f")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "parameter_x_is_some_type_or_optional_then_assigned_with_alternate_value")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local function f(x: number?)
|
|
x = x or 5
|
|
return x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("(number?) -> number" == toString(requireType("f")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "local_assigned_in_either_branches_that_falls_through")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x = nil
|
|
if math.random() > 0.5 then
|
|
x = 5
|
|
else
|
|
x = "hello"
|
|
end
|
|
local y = x
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("number | string" == toString(requireType("y")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "local_assigned_in_only_one_branch_that_falls_through")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x = nil
|
|
if math.random() > 0.5 then
|
|
x = 5
|
|
end
|
|
local y = x
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("number?" == toString(requireType("y")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "then_branch_assigns_and_else_branch_also_assigns_but_is_met_with_return")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x = nil
|
|
if math.random() > 0.5 then
|
|
x = 5
|
|
else
|
|
x = "hello"
|
|
return
|
|
end
|
|
local y = x
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("number?" == toString(requireType("y")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(TypeStateFixture, "then_branch_assigns_but_is_met_with_return_and_else_branch_assigns")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x = nil
|
|
if math.random() > 0.5 then
|
|
x = 5
|
|
return
|
|
else
|
|
x = "hello"
|
|
end
|
|
local y = x
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK("string?" == toString(requireType("y")));
|
|
}
|
|
|
|
TEST_SUITE_END();
|