mirror of
https://github.com/luau-lang/luau.git
synced 2025-04-02 01:40:54 +01:00
Another week, another release. Happy spring! 🌷 ## New Type Solver - Add typechecking and autocomplete support for user-defined type functions! - Improve the display of type paths, making type mismatch errors far more human-readable. - Enhance various aspects of the `index` type function: support function type metamethods, fix crashes involving cyclic metatables, and forward `any` types through the type function. - Fix incorrect subtyping results involving the `buffer` type. - Fix crashes related to typechecking anonymous functions in nonstrict mode. ## AST - Retain source information for type packs, functions, and type functions. - Introduce `AstTypeOptional` to differentiate `T?` from `T | nil` in the AST. - Prevent the transpiler from advancing before tokens when the AST has errors. ## Autocomplete - Introduce demand-based cloning and better module isolation for fragment autocomplete, leading to a substantial speedup in performance. - Guard against recursive unions in `autocompleteProps`. ## Miscellaneous - #1720 (thank you!) ## Internal Contributors Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Ariel Weiss <aaronweiss@roblox.com> Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com> Co-authored-by: Talha Pathan <tpathan@roblox.com> Co-authored-by: Vighnesh Vijay <vvijay@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
230 lines
6.4 KiB
C++
230 lines
6.4 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
#include "Luau/RequireTracer.h"
|
|
#include "Luau/Parser.h"
|
|
|
|
#include "Fixture.h"
|
|
|
|
#include "doctest.h"
|
|
|
|
using namespace Luau;
|
|
|
|
namespace
|
|
{
|
|
|
|
struct RequireTracerFixture
|
|
{
|
|
RequireTracerFixture()
|
|
: allocator()
|
|
, names(allocator)
|
|
{
|
|
}
|
|
|
|
AstStatBlock* parse(std::string_view src)
|
|
{
|
|
ParseResult result = Parser::parse(src.data(), src.size(), names, allocator, ParseOptions{});
|
|
if (!result.errors.empty())
|
|
{
|
|
std::string message;
|
|
|
|
for (const auto& error : result.errors)
|
|
{
|
|
if (!message.empty())
|
|
message += "\n";
|
|
|
|
message += error.what();
|
|
}
|
|
|
|
printf("Parse error: %s\n", message.c_str());
|
|
return nullptr;
|
|
}
|
|
else
|
|
return result.root;
|
|
}
|
|
|
|
Allocator allocator;
|
|
AstNameTable names;
|
|
|
|
Luau::TestFileResolver fileResolver;
|
|
};
|
|
|
|
const std::vector<std::string> roots = {"game", "Game", "workspace", "Workspace", "script"};
|
|
|
|
} // namespace
|
|
|
|
TEST_SUITE_BEGIN("RequireTracerTest");
|
|
|
|
TEST_CASE_FIXTURE(RequireTracerFixture, "trace_local")
|
|
{
|
|
AstStatBlock* block = parse(R"(
|
|
local m = workspace.Foo.Bar.Baz
|
|
require(m)
|
|
)");
|
|
|
|
RequireTraceResult result = traceRequires(&fileResolver, block, "ModuleName");
|
|
REQUIRE(!result.exprs.empty());
|
|
|
|
AstStatLocal* loc = block->body.data[0]->as<AstStatLocal>();
|
|
REQUIRE(loc);
|
|
REQUIRE_EQ(1, loc->vars.size);
|
|
REQUIRE_EQ(1, loc->values.size);
|
|
|
|
AstExprIndexName* value = loc->values.data[0]->as<AstExprIndexName>();
|
|
REQUIRE(value);
|
|
REQUIRE(result.exprs.contains(value));
|
|
CHECK_EQ("workspace/Foo/Bar/Baz", result.exprs[value].name);
|
|
|
|
value = value->expr->as<AstExprIndexName>();
|
|
REQUIRE(value);
|
|
REQUIRE(result.exprs.contains(value));
|
|
CHECK_EQ("workspace/Foo/Bar", result.exprs[value].name);
|
|
|
|
value = value->expr->as<AstExprIndexName>();
|
|
REQUIRE(value);
|
|
REQUIRE(result.exprs.contains(value));
|
|
CHECK_EQ("workspace/Foo", result.exprs[value].name);
|
|
|
|
AstExprGlobal* workspace = value->expr->as<AstExprGlobal>();
|
|
REQUIRE(workspace);
|
|
REQUIRE(result.exprs.contains(workspace));
|
|
CHECK_EQ("workspace", result.exprs[workspace].name);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(RequireTracerFixture, "trace_transitive_local")
|
|
{
|
|
AstStatBlock* block = parse(R"(
|
|
local m = workspace.Foo.Bar.Baz
|
|
local n = m.Quux
|
|
require(n)
|
|
)");
|
|
|
|
REQUIRE_EQ(3, block->body.size);
|
|
|
|
RequireTraceResult result = traceRequires(&fileResolver, block, "ModuleName");
|
|
|
|
AstStatLocal* local = block->body.data[1]->as<AstStatLocal>();
|
|
REQUIRE(local);
|
|
REQUIRE_EQ(1, local->vars.size);
|
|
|
|
REQUIRE(result.exprs.contains(local->values.data[0]));
|
|
CHECK_EQ("workspace/Foo/Bar/Baz/Quux", result.exprs[local->values.data[0]].name);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(RequireTracerFixture, "trace_function_arguments")
|
|
{
|
|
AstStatBlock* block = parse(R"(
|
|
local M = require(workspace.Game.Thing)
|
|
)");
|
|
REQUIRE_EQ(1, block->body.size);
|
|
|
|
RequireTraceResult result = traceRequires(&fileResolver, block, "ModuleName");
|
|
|
|
AstStatLocal* local = block->body.data[0]->as<AstStatLocal>();
|
|
REQUIRE(local != nullptr);
|
|
REQUIRE_EQ(1, local->vars.size);
|
|
REQUIRE_EQ(1, local->values.size);
|
|
|
|
AstExprCall* call = local->values.data[0]->as<AstExprCall>();
|
|
REQUIRE(call != nullptr);
|
|
|
|
REQUIRE_EQ(1, call->args.size);
|
|
|
|
CHECK_EQ("workspace/Game/Thing", result.exprs[call->args.data[0]].name);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(RequireTracerFixture, "follow_typeof")
|
|
{
|
|
AstStatBlock* block = parse(R"(
|
|
local R: typeof(require(workspace.CoolThing).UsefulObject)
|
|
)");
|
|
REQUIRE_EQ(1, block->body.size);
|
|
|
|
RequireTraceResult result = traceRequires(&fileResolver, block, "ModuleName");
|
|
|
|
AstStatLocal* local = block->body.data[0]->as<AstStatLocal>();
|
|
REQUIRE(local != nullptr);
|
|
|
|
REQUIRE_EQ(local->vars.size, 1);
|
|
|
|
AstType* ann = local->vars.data[0]->annotation;
|
|
REQUIRE(ann != nullptr);
|
|
|
|
AstTypeTypeof* typeofAnnotation = ann->as<AstTypeTypeof>();
|
|
REQUIRE(typeofAnnotation != nullptr);
|
|
|
|
AstExprIndexName* indexName = typeofAnnotation->expr->as<AstExprIndexName>();
|
|
REQUIRE(indexName != nullptr);
|
|
REQUIRE_EQ(indexName->index, "UsefulObject");
|
|
|
|
AstExprCall* call = indexName->expr->as<AstExprCall>();
|
|
REQUIRE(call != nullptr);
|
|
REQUIRE_EQ(1, call->args.size);
|
|
|
|
CHECK_EQ("workspace/CoolThing", result.exprs[call->args.data[0]].name);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(RequireTracerFixture, "follow_string_indexexpr")
|
|
{
|
|
AstStatBlock* block = parse(R"(
|
|
local R = game["Test"]
|
|
require(R)
|
|
)");
|
|
REQUIRE_EQ(2, block->body.size);
|
|
|
|
RequireTraceResult result = traceRequires(&fileResolver, block, "ModuleName");
|
|
|
|
AstStatLocal* local = block->body.data[0]->as<AstStatLocal>();
|
|
REQUIRE(local != nullptr);
|
|
|
|
CHECK_EQ("game/Test", result.exprs[local->values.data[0]].name);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(RequireTracerFixture, "follow_group")
|
|
{
|
|
AstStatBlock* block = parse(R"(
|
|
local R = (((game).Test))
|
|
require(R)
|
|
)");
|
|
REQUIRE_EQ(2, block->body.size);
|
|
|
|
RequireTraceResult result = traceRequires(&fileResolver, block, "ModuleName");
|
|
|
|
AstStatLocal* local = block->body.data[0]->as<AstStatLocal>();
|
|
REQUIRE(local != nullptr);
|
|
|
|
CHECK_EQ("game/Test", result.exprs[local->values.data[0]].name);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(RequireTracerFixture, "follow_type_annotation")
|
|
{
|
|
AstStatBlock* block = parse(R"(
|
|
local R = game.Test :: (typeof(game.Redirect))
|
|
require(R)
|
|
)");
|
|
REQUIRE_EQ(2, block->body.size);
|
|
|
|
RequireTraceResult result = traceRequires(&fileResolver, block, "ModuleName");
|
|
|
|
AstStatLocal* local = block->body.data[0]->as<AstStatLocal>();
|
|
REQUIRE(local != nullptr);
|
|
|
|
CHECK_EQ("game/Redirect", result.exprs[local->values.data[0]].name);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(RequireTracerFixture, "follow_type_annotation_2")
|
|
{
|
|
AstStatBlock* block = parse(R"(
|
|
local R = game.Test :: (typeof(game.Redirect))
|
|
local N = R.Nested
|
|
require(N)
|
|
)");
|
|
REQUIRE_EQ(3, block->body.size);
|
|
|
|
RequireTraceResult result = traceRequires(&fileResolver, block, "ModuleName");
|
|
|
|
AstStatLocal* local = block->body.data[1]->as<AstStatLocal>();
|
|
REQUIRE(local != nullptr);
|
|
|
|
CHECK_EQ("game/Redirect/Nested", result.exprs[local->values.data[0]].name);
|
|
}
|
|
|
|
TEST_SUITE_END();
|