mirror of
https://github.com/luau-lang/luau.git
synced 2025-04-19 11:13:49 +01:00
80928acb92
Instead of patching the tag component with TVECTOR in every instruction that produces a vector value, we now use a separate IR instruction to do this. This reduces implementation redundancy, but more importantly allows for a class of optimizations: - NUM_TO_VECTOR previously patched the component unconditionally but the result was used only in MUL/DIV_VEC instructions that ignore it anyway; we can now remove this. - ADD_VEC et al can now forward the source of TAG_VECTOR instruction of either input; this shortens the latency chain and in the future could allow us to generate optimal vector instruction sequence once the temporary stores are marked as dead. - In the future on X64, ADD_VEC et al will be able to analyze the input instruction and remove tag masking conditionally. This is not part of this PR as it requires a decision around expected FP environment and/or the necessity of the existing masking to begin with. I've also renamed NUM_TO_VECTOR to NUM_TO_VEC so that "VEC" always refers to "3 float values" and for consistency with ADD/etc. Note: ADD_VEC input forwarding is currently performed unconditionally; it may or may not increase the spills that can't be reloaded from the stack. On A64 this makes the Taylor series computation a tiny bit faster (11.3ns => 11.0ns) as it removes the redundant ins instructions along the NUM_TO_VEC path. Curiously, the optimization of forwarding TAG_VECTOR input to arithmetic instructions actually has a small penalty as without it this PR runs at 10.9 ns. I don't know if this is a property of the benchmark though, as I just noticed that in this benchmark type inference actually fails to infer parts of the computation as a vector op. If desired I will happily omit this part of the change and we can explore that separately. |
||
|---|---|---|
| .. | ||
| AssemblyBuilderA64.cpp | ||
| AssemblyBuilderX64.cpp | ||
| BitUtils.h | ||
| BytecodeAnalysis.cpp | ||
| BytecodeSummary.cpp | ||
| ByteUtils.h | ||
| CodeAllocator.cpp | ||
| CodeBlockUnwind.cpp | ||
| CodeGen.cpp | ||
| CodeGenA64.cpp | ||
| CodeGenA64.h | ||
| CodeGenAssembly.cpp | ||
| CodeGenLower.h | ||
| CodeGenUtils.cpp | ||
| CodeGenUtils.h | ||
| CodeGenX64.cpp | ||
| CodeGenX64.h | ||
| EmitBuiltinsX64.cpp | ||
| EmitBuiltinsX64.h | ||
| EmitCommon.h | ||
| EmitCommonA64.h | ||
| EmitCommonX64.cpp | ||
| EmitCommonX64.h | ||
| EmitInstructionX64.cpp | ||
| EmitInstructionX64.h | ||
| IrAnalysis.cpp | ||
| IrBuilder.cpp | ||
| IrCallWrapperX64.cpp | ||
| IrDump.cpp | ||
| IrLoweringA64.cpp | ||
| IrLoweringA64.h | ||
| IrLoweringX64.cpp | ||
| IrLoweringX64.h | ||
| IrRegAllocA64.cpp | ||
| IrRegAllocA64.h | ||
| IrRegAllocX64.cpp | ||
| IrTranslateBuiltins.cpp | ||
| IrTranslateBuiltins.h | ||
| IrTranslation.cpp | ||
| IrTranslation.h | ||
| IrUtils.cpp | ||
| IrValueLocationTracking.cpp | ||
| IrValueLocationTracking.h | ||
| lcodegen.cpp | ||
| NativeState.cpp | ||
| NativeState.h | ||
| OptimizeConstProp.cpp | ||
| OptimizeFinalX64.cpp | ||
| UnwindBuilderDwarf2.cpp | ||
| UnwindBuilderWin.cpp | ||