luau-lang/luau
1
0
Fork 0
mirror of https://github.com/luau-lang/luau.git synced 2025-05-04 10:33:46 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix crash when require is called from root VM stack (#1788)

Browse source 
Copied from #1785:
> If require is called from the root interpreter stack (e.g. using C
API) then lua_getinfo call will not succeed, leaving garbage in
lua_Debug ar struct.
> Accessing later ar.source as null-terminated string is unsafe and can
cause a crash.
> 
> This PR adds a check to ensure that lua_getinfo call is successful.

Co-authored-by: Alex Orlenko <zxteam@protonmail.com>
This commit is contained in:
Varun Saini 2025-04-28 11:15:43 -07:00 • committed by GitHub
parent c51743268b
commit d9aa88e772
Signed by: DevComp
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Require/Runtime/src/RequireImpl.cpp
View file

@ -170,7 +170,8 @@ int lua_proxyrequire(lua_State* L)
int lua_require(lua_State* L) int lua_require(lua_State* L)
{ {
lua_Debug ar; lua_Debug ar;
lua_getinfo(L, 1, "s", &ar); if (!lua_getinfo(L, 1, "s", &ar))
luaL_error(L, "require is not supported in this context");
return lua_requireinternal(L, ar.source); return lua_requireinternal(L, ar.source);
} }