luau-lang/luau
1
0
Fork 0
mirror of https://github.com/luau-lang/luau.git synced 2025-04-03 02:10:53 +01:00
Code Issues Projects Releases Packages Wiki Activity

parse table type ["hello"] as an indexer instead of a prop

Browse source
This commit is contained in:
jackdotink 2024-07-10 15:19:29 -05:00
parent 6bfc38e61a
commit 6d2806dd72
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Ast/src/Parser.cpp
View file

@ -22,6 +22,7 @@ LUAU_FASTFLAGVARIABLE(LuauLeadingBarAndAmpersand2, false)
LUAU_FASTFLAGVARIABLE(LuauNativeAttribute, false)
LUAU_FASTFLAGVARIABLE(LuauAttributeSyntaxFunExpr, false)
LUAU_FASTFLAGVARIABLE(LuauDeclarationExtraPropData, false)
LUAU_FASTFLAGVARIABLE(LuauBracketStringsAreNotProps, false)
namespace Luau
{
@ -1536,7 +1537,7 @@ AstType* Parser::parseTableType(bool inDeclarationContext)
}
}
if (lexer.current().type == '[' && (lexer.lookahead().type == Lexeme::RawString || lexer.lookahead().type == Lexeme::QuotedString))
if (!FFlag::LuauBracketStringsAreNotProps && lexer.current().type == '[' && (lexer.lookahead().type == Lexeme::RawString || lexer.lookahead().type == Lexeme::QuotedString))
{
const Lexeme begin = lexer.current();
nextLexeme(); // [

9
tests/Parser.test.cpp
View file

@ -20,6 +20,7 @@ LUAU_FASTFLAG(LuauAttributeSyntax);
LUAU_FASTFLAG(LuauLeadingBarAndAmpersand2);
LUAU_FASTFLAG(LuauAttributeSyntaxFunExpr);
LUAU_FASTFLAG(LuauDeclarationExtraPropData);
LUAU_FASTFLAG(LuauBracketStringsAreNotProps);
namespace
{
@ -3565,5 +3566,13 @@ TEST_CASE_FIXTURE(Fixture, "mixed_leading_intersection_and_union_not_allowed")
matchParseError("type A = | number & string & boolean", "Mixing union and intersection types is not allowed; consider wrapping in parentheses.");
}
TEST_CASE_FIXTURE(Fixture, "can_parse_string_intersection_or_union_in_table_type_indexer_successfully")
{
ScopedFastFlag sff{FFlag::LuauBracketStringsAreNotProps, true};
parse(R"(type A = { ["foo" | "bar"]: baz })");
parse(R"(type A = { ["foo" & "bar"]: baz })");
}
TEST_SUITE_END();