luau-lang/luau
1
0
Fork 0
mirror of https://github.com/luau-lang/luau.git synced 2025-04-03 02:10:53 +01:00
Code Issues Projects Releases Packages Wiki Activity

Update Unifier2.cpp

Browse source 
Better conditional formatting leads to around 40% less computations.
This commit is contained in:
RobertP2705 2025-03-19 15:37:38 -05:00 • committed by GitHub
parent e0b55a9cb1
commit 5f94885fe5
Signed by: DevComp
GPG key ID: B5690EEEBB952194
1 changed files with 32 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
Analysis/src/Unifier2.cpp
View file

@ -210,17 +210,20 @@ bool Unifier2::unify(TypeId subTy, TypeId superTy)
auto subTable = getMutable<TableType>(subTy); auto subTable = getMutable<TableType>(subTy);
auto superTable = get<TableType>(superTy); auto superTable = get<TableType>(superTy);
if (subAny && superAny) if (subAny && superAny)
return true; return true;
else if (subAny && superFn) if (subAny) {
return unify(subAny, superFn); if (superFn)
else if (subFn && superAny) return unify(subAny, superFn);
return unify(subFn, superAny); if (superTable)
else if (subAny && superTable) return unify(subAny, superTable);
return unify(subAny, superTable); }
else if (subTable && superAny) if (superAny) {
return unify(subTable, superAny); if (subFn)
return unify(subFn, superAny);
if (subTable)
return unify(subTable, superAny);
}
if (subTable && superTable) if (subTable && superTable)
{ {
// `boundTo` works like a bound type, and therefore we'd replace it // `boundTo` works like a bound type, and therefore we'd replace it
@ -235,17 +238,25 @@ bool Unifier2::unify(TypeId subTy, TypeId superTy)
auto subMetatable = get<MetatableType>(subTy); auto subMetatable = get<MetatableType>(subTy);
auto superMetatable = get<MetatableType>(superTy); auto superMetatable = get<MetatableType>(superTy);
if (subMetatable && superMetatable)
return unify(subMetatable, superMetatable); // Cache the flag value to avoid multiple checks
else if (FFlag::LuauUnifyMetatableWithAny && subMetatable && superAny) const bool flagEnabled = FFlag::LuauUnifyMetatableWithAny;
return unify(subMetatable, superAny);
else if (FFlag::LuauUnifyMetatableWithAny && subAny && superMetatable) if (subMetatable) {
return unify(subAny, superMetatable); if (superMetatable)
else if (subMetatable) // if we only have one metatable, unify with the inner table return unify(subMetatable, superMetatable);
return unify(subMetatable->table, superTy); else if (flagEnabled && superAny)
else if (superMetatable) // if we only have one metatable, unify with the inner table return unify(subMetatable, superAny);
return unify(subTy, superMetatable->table); else
return unify(subMetatable->table, superTy); // if we only have one metatable, unify with the inner table
}
else if (superMetatable) {
if (flagEnabled && subAny)
return unify(subAny, superMetatable);
else
return unify(subTy, superMetatable->table); // if we only have one metatable, unify with the inner table
}
auto [subNegation, superNegation] = get2<NegationType, NegationType>(subTy, superTy); auto [subNegation, superNegation] = get2<NegationType, NegationType>(subTy, superTy);
if (subNegation && superNegation) if (subNegation && superNegation)
return unify(subNegation->ty, superNegation->ty); return unify(subNegation->ty, superNegation->ty);