luau-lang/luau
1
0
Fork 0
mirror of https://github.com/luau-lang/luau.git synced 2024-12-12 13:00:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix mesh-normal-vector benchmark array access (#1514)

Browse source 
mesh-normal-scalar correctly fills sequential values in the output for
triangle cone function, but mesh-normal-vector accidentally reuses the
loop index, which results in writes to every third index of the array
(1, 4, etc.).

This is both slower (as the table turns into a hash map), and incorrect,
especially as we have a scalar version of the benchmark that does the
right thing.

Note: there's a bunch of inefficiencies in the benchmark code that I
have not fixed (around field access mostly, e.g. writing to `v.n` and
then immediately reading it again). These are not ideal for performance,
but they can be valuable to keep as is because this redundancy is common
in real-world code, and it would be nice to see codegen optimizations
eliminating most of that overhead. This one, however, is a straight up
bug, and sparse arrays should not really be the thing this benchmark
hits.
This commit is contained in:
Arseny Kapoulkine 2024-11-11 12:39:09 -08:00 committed by GitHub
parent e6bf71871a
commit 53e6e4b8f0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
bench/tests/mesh-normal-vector.lua
View file

@ -86,7 +86,8 @@ function test()
function compute_triangle_cones() function compute_triangle_cones()
local mesh_area = 0 local mesh_area = 0
local i = 1 local pos = 1
for i = 1,#mesh.indices,3 do for i = 1,#mesh.indices,3 do
local p0 = mesh.vertices[mesh.indices[i]] local p0 = mesh.vertices[mesh.indices[i]]
local p1 = mesh.vertices[mesh.indices[i + 1]] local p1 = mesh.vertices[mesh.indices[i + 1]]
@ -100,9 +101,9 @@ function test()
local area = vector.magnitude(normal) local area = vector.magnitude(normal)
local invarea = (area == 0) and 0 or 1 / area; local invarea = (area == 0) and 0 or 1 / area;
mesh.triangle_cone_p[i] = (p0.p + p1.p + p2.p) / 3 mesh.triangle_cone_p[pos] = (p0.p + p1.p + p2.p) / 3
mesh.triangle_cone_n[i] = normal * invarea mesh.triangle_cone_n[pos] = normal * invarea
i += 1 pos += 1
mesh_area += area mesh_area += area
end end