2024-04-12 10:18:49 -07:00
|
|
|
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
|
|
|
|
|
|
#include "Luau/Instantiation2.h"
|
|
|
|
|
|
|
|
#include "Fixture.h"
|
|
|
|
#include "ClassFixture.h"
|
Sync to upstream/release/660 (#1643)
# General
This release introduces initial work on a Roundtrippable AST for Luau,
and numerous fixes to the new type solver, runtime, and fragment
autocomplete.
## Roundtrippable AST
To support tooling around source code transformations, we are extending
the parser to retain source information so that we can re-emit the
initial source code exactly as the author wrote it. We have made
numerous changes to the Transpiler, added new AST types such as
`AstTypeGroup`, and added source information to AST nodes such as
`AstExprInterpString`, `AstExprIfElse`, `AstTypeTable`,
`AstTypeReference`, `AstTypeSingletonString`, and `AstTypeTypeof`.
## New Type Solver
* Implement `setmetatable` and `getmetatable` type functions.
* Fix handling of nested and recursive union type functions to prevent
the solver from getting stuck.
* Free types in both old and new solver now have an upper and lower
bound to resolve mixed mode usage of the solvers in fragment
autocomplete.
* Fix infinite recursion during normalization of cyclic tables.
* Add normalization support for intersections of subclasses with negated
superclasses.
## Runtime
* Fix compilation error in Luau buffer bit operations for big-endian
machines.
## Miscellaneous
* Add test and bugfixes to fragment autocomplete.
* Fixed `clang-tidy` warnings in `Simplify.cpp`.
**Full Changelog**:
https://github.com/luau-lang/luau/compare/0.659...0.660
---
Co-authored-by: Ariel Weiss <aaronweiss@roblox.com>
Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com>
Co-authored-by: Talha Pathan <tpathan@roblox.com>
Co-authored-by: Varun Saini <vsaini@roblox.com>
Co-authored-by: Vighnesh Vijay <vvijay@roblox.com>
Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
---------
Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com>
Co-authored-by: Varun Saini <61795485+vrn-sn@users.noreply.github.com>
Co-authored-by: Alexander Youngblood <ayoungblood@roblox.com>
Co-authored-by: Menarul Alam <malam@roblox.com>
2025-02-07 16:17:11 -08:00
|
|
|
#include "Luau/Type.h"
|
2024-04-12 10:18:49 -07:00
|
|
|
#include "ScopedFlags.h"
|
|
|
|
|
|
|
|
#include "doctest.h"
|
|
|
|
|
|
|
|
using namespace Luau;
|
|
|
|
|
|
|
|
TEST_SUITE_BEGIN("Instantiation2Test");
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "weird_cyclic_instantiation")
|
|
|
|
{
|
|
|
|
TypeArena arena;
|
|
|
|
Scope scope(builtinTypes->anyTypePack);
|
|
|
|
|
|
|
|
TypeId genericT = arena.addType(GenericType{"T"});
|
|
|
|
|
2024-08-02 07:30:04 -07:00
|
|
|
TypeId idTy = arena.addType(FunctionType{
|
|
|
|
/* generics */ {genericT},
|
2024-04-12 10:18:49 -07:00
|
|
|
/* genericPacks */ {},
|
|
|
|
/* argTypes */ arena.addTypePack({genericT}),
|
2024-08-02 07:30:04 -07:00
|
|
|
/* retTypes */ arena.addTypePack({genericT})
|
|
|
|
});
|
2024-04-12 10:18:49 -07:00
|
|
|
|
|
|
|
DenseHashMap<TypeId, TypeId> genericSubstitutions{nullptr};
|
|
|
|
DenseHashMap<TypePackId, TypePackId> genericPackSubstitutions{nullptr};
|
|
|
|
|
Sync to upstream/release/660 (#1643)
# General
This release introduces initial work on a Roundtrippable AST for Luau,
and numerous fixes to the new type solver, runtime, and fragment
autocomplete.
## Roundtrippable AST
To support tooling around source code transformations, we are extending
the parser to retain source information so that we can re-emit the
initial source code exactly as the author wrote it. We have made
numerous changes to the Transpiler, added new AST types such as
`AstTypeGroup`, and added source information to AST nodes such as
`AstExprInterpString`, `AstExprIfElse`, `AstTypeTable`,
`AstTypeReference`, `AstTypeSingletonString`, and `AstTypeTypeof`.
## New Type Solver
* Implement `setmetatable` and `getmetatable` type functions.
* Fix handling of nested and recursive union type functions to prevent
the solver from getting stuck.
* Free types in both old and new solver now have an upper and lower
bound to resolve mixed mode usage of the solvers in fragment
autocomplete.
* Fix infinite recursion during normalization of cyclic tables.
* Add normalization support for intersections of subclasses with negated
superclasses.
## Runtime
* Fix compilation error in Luau buffer bit operations for big-endian
machines.
## Miscellaneous
* Add test and bugfixes to fragment autocomplete.
* Fixed `clang-tidy` warnings in `Simplify.cpp`.
**Full Changelog**:
https://github.com/luau-lang/luau/compare/0.659...0.660
---
Co-authored-by: Ariel Weiss <aaronweiss@roblox.com>
Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com>
Co-authored-by: Talha Pathan <tpathan@roblox.com>
Co-authored-by: Varun Saini <vsaini@roblox.com>
Co-authored-by: Vighnesh Vijay <vvijay@roblox.com>
Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
---------
Co-authored-by: Hunter Goldstein <hgoldstein@roblox.com>
Co-authored-by: Varun Saini <61795485+vrn-sn@users.noreply.github.com>
Co-authored-by: Alexander Youngblood <ayoungblood@roblox.com>
Co-authored-by: Menarul Alam <malam@roblox.com>
2025-02-07 16:17:11 -08:00
|
|
|
TypeId freeTy = arena.freshType(builtinTypes, &scope);
|
2024-04-12 10:18:49 -07:00
|
|
|
FreeType* ft = getMutable<FreeType>(freeTy);
|
|
|
|
REQUIRE(ft);
|
|
|
|
ft->lowerBound = idTy;
|
|
|
|
ft->upperBound = builtinTypes->unknownType;
|
|
|
|
|
|
|
|
genericSubstitutions[genericT] = freeTy;
|
|
|
|
|
|
|
|
CHECK("<T>(T) -> T" == toString(idTy));
|
|
|
|
|
|
|
|
std::optional<TypeId> res = instantiate2(&arena, std::move(genericSubstitutions), std::move(genericPackSubstitutions), idTy);
|
|
|
|
|
|
|
|
// Substitutions should not mutate the original type!
|
|
|
|
CHECK("<T>(T) -> T" == toString(idTy));
|
|
|
|
|
|
|
|
REQUIRE(res);
|
2024-08-02 07:30:04 -07:00
|
|
|
CHECK("<T>(T) -> T" == toString(*res));
|
2024-04-12 10:18:49 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST_SUITE_END();
|