0x5eal/luau-unzip
1
1
Fork 0
mirror of https://github.com/0x5eal/luau-unzip.git synced 2025-04-02 22:00:53 +01:00
Code Issues Projects Releases Packages Wiki Activity

fix: relax size checks and move test to edge case

Browse source 
Relaxed size checks to not error for empty ZIP files in other test
cases, and only validate that the number of entries is 0 for our test
case, moving it to the edge cases suite instead.
This commit is contained in:
Erica Marigold 2025-02-24 07:39:35 +00:00
parent 39009b734c
commit ee4d0e1a8d
Signed by: DevComp
SSH key fingerprint: SHA256:jD3oMT4WL3WHPJQbrjC3l5feNCnkv7ndW8nYaHX5wFw
3 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/init.luau
View file

@ -531,10 +531,9 @@ function ZipReader.parseEocdRecord(self: ZipReader, pos: number): EocdRecord
local cdSize = buffer.readu32(self.data, pos + 12) local cdSize = buffer.readu32(self.data, pos + 12)
local cdOffset = buffer.readu32(self.data, pos + 16) local cdOffset = buffer.readu32(self.data, pos + 16)
-- Validate CD boundaries and entry count; Ensure minimum size is at least 30 bytes and -- Validate CD boundaries and entry count
-- total size after the local header is not larger than the buffer size
local bufSize = buffer.len(self.data) local bufSize = buffer.len(self.data)
if cdOffset >= bufSize or cdOffset < 30 or cdOffset + cdSize > bufSize then if cdOffset >= bufSize or cdOffset + cdSize > bufSize then
error("Invalid Central Directory offset or size") error("Invalid Central Directory offset or size")
end end

7
tests/edge_cases.luau
View file

@ -79,5 +79,12 @@ return function(test: typeof(frktest.test))
-- Check that the comment is the same as the one in the ZIP file (only compare hashes) -- Check that the comment is the same as the one in the ZIP file (only compare hashes)
check.equal(serde.hash("blake3", commentData), serde.hash("blake3", zip.comment)) check.equal(serde.hash("blake3", commentData), serde.hash("blake3", zip.comment))
end) end)
test.case("Does not over alllocate based on declared entry count in EoCD", function()
local data = fs.readFile("tests/data/invalid_cde_number_of_files_allocation_smaller_offset.zip")
local zip = ZipReader.load(buffer.fromstring(data))
check.is_true(#zip.entries == 0)
end)
end) end)
end end

2
tests/extract.luau
View file

@ -10,7 +10,7 @@ local ZipReader = require("../lib")
local ZIPS = fs.readDir("tests/data") local ZIPS = fs.readDir("tests/data")
local FALLIBLES = { local FALLIBLES = {
"invalid_cde_number_of_files_allocation_greater_offset.zip", "invalid_cde_number_of_files_allocation_greater_offset.zip",
"invalid_cde_number_of_files_allocation_smaller_offset.zip", -- "invalid_cde_number_of_files_allocation_smaller_offset.zip", -- Tested separately in edge cases
"invalid_offset.zip", "invalid_offset.zip",
"invalid_offset2.zip", "invalid_offset2.zip",
"chinese.zip", -- Contains non local specific encoding which can't be parsed without OS APIs "chinese.zip", -- Contains non local specific encoding which can't be parsed without OS APIs