refactor: minor sylistic changes

Swaps places with the pattern:
```luau
x = x + 1
```

to use:
```luau
x += 1
```
This commit is contained in:
Erica Marigold 2024-12-30 11:26:22 +00:00
parent c2e638cbec
commit 10a399c91f
Signed by: DevComp
GPG key ID: 429EF1C337871656
2 changed files with 255 additions and 256 deletions

View file

@ -2,49 +2,49 @@ local Tree = {}
export type Tree = typeof(setmetatable({} :: TreeInner, { __index = Tree })) export type Tree = typeof(setmetatable({} :: TreeInner, { __index = Tree }))
type TreeInner = { type TreeInner = {
table: { number }, -- len: 16 (🏳️‍⚧️❓) table: { number }, -- len: 16
trans: { number }, -- len: 288 trans: { number }, -- len: 288
} }
function Tree.new(): Tree function Tree.new(): Tree
return setmetatable( return setmetatable(
{ {
table = table.create(16, 0), table = table.create(16, 0),
trans = table.create(288, 0), trans = table.create(288, 0),
} :: TreeInner, } :: TreeInner,
{ __index = Tree } { __index = Tree }
) )
end end
local Data = {} local Data = {}
export type Data = typeof(setmetatable({} :: DataInner, { __index = Data })) export type Data = typeof(setmetatable({} :: DataInner, { __index = Data }))
export type DataInner = { export type DataInner = {
source: buffer, source: buffer,
sourceIndex: number, sourceIndex: number,
tag: number, tag: number,
bitcount: number, bitcount: number,
dest: buffer, dest: buffer,
destLen: number, destLen: number,
ltree: Tree, ltree: Tree,
dtree: Tree, dtree: Tree,
} }
function Data.new(source: buffer, dest: buffer): Data function Data.new(source: buffer, dest: buffer): Data
return setmetatable( return setmetatable(
{ {
source = source, source = source,
sourceIndex = 0, sourceIndex = 0,
tag = 0, tag = 0,
bitcount = 0, bitcount = 0,
dest = dest, dest = dest,
destLen = 0, destLen = 0,
ltree = Tree.new(), ltree = Tree.new(),
dtree = Tree.new(), dtree = Tree.new(),
} :: DataInner, } :: DataInner,
{ __index = Data } { __index = Data }
) )
end end
-- Static structures -- Static structures
@ -58,7 +58,6 @@ local distBits = table.create(30, 0)
local distBase = table.create(30, 0) local distBase = table.create(30, 0)
-- Special ordering of code length codes -- Special ordering of code length codes
-- stylua: ignore
local clcIndex = { local clcIndex = {
16, 17, 18, 0, 8, 7, 9, 6, 16, 17, 18, 0, 8, 7, 9, 6,
10, 5, 11, 4, 12, 3, 13, 2, 10, 5, 11, 4, 12, 3, 13, 2,
@ -69,270 +68,270 @@ local codeTree = Tree.new()
local lengths = table.create(288 + 32, 0) local lengths = table.create(288 + 32, 0)
local function buildBitsBase(bits: { number }, base: { number }, delta: number, first: number) local function buildBitsBase(bits: { number }, base: { number }, delta: number, first: number)
local sum = first local sum = first
-- build bits table -- build bits table
for i = 0, delta - 1 do for i = 0, delta - 1 do
bits[i] = 0 bits[i] = 0
end end
for i = 0, 29 - delta do for i = 0, 29 - delta do
bits[i + delta] = math.floor(i / delta) bits[i + delta] = math.floor(i / delta)
end end
-- build base table -- build base table
for i = 0, 29 do for i = 0, 29 do
base[i] = sum base[i] = sum
sum = sum + bit32.lshift(1, bits[i]) sum += bit32.lshift(1, bits[i])
end end
end end
local function buildFixedTrees(lengthTree: Tree, distTree: Tree) local function buildFixedTrees(lengthTree: Tree, distTree: Tree)
-- build fixed length tree -- build fixed length tree
for i = 0, 6 do for i = 0, 6 do
lengthTree.table[i] = 0 lengthTree.table[i] = 0
end end
lengthTree.table[7] = 24 lengthTree.table[7] = 24
lengthTree.table[8] = 152 lengthTree.table[8] = 152
lengthTree.table[9] = 112 lengthTree.table[9] = 112
for i = 0, 23 do for i = 0, 23 do
lengthTree.trans[i] = 256 + i lengthTree.trans[i] = 256 + i
end end
for i = 0, 143 do for i = 0, 143 do
lengthTree.trans[24 + i] = i lengthTree.trans[24 + i] = i
end end
for i = 0, 7 do for i = 0, 7 do
lengthTree.trans[24 + 144 + i] = 280 + i lengthTree.trans[24 + 144 + i] = 280 + i
end end
for i = 0, 111 do for i = 0, 111 do
lengthTree.trans[24 + 144 + 8 + i] = 144 + i lengthTree.trans[24 + 144 + 8 + i] = 144 + i
end end
-- build fixed distance tree -- build fixed distance tree
for i = 0, 4 do for i = 0, 4 do
distTree.table[i] = 0 distTree.table[i] = 0
end end
distTree.table[5] = 32 distTree.table[5] = 32
for i = 0, 31 do for i = 0, 31 do
distTree.trans[i] = i distTree.trans[i] = i
end end
end end
local offs = table.create(16, 0) local offs = table.create(16, 0)
local function buildTree(t: Tree, lengths: { number }, off: number, num: number) local function buildTree(t: Tree, lengths: { number }, off: number, num: number)
-- clear code length count table -- clear code length count table
for i = 0, 15 do for i = 0, 15 do
t.table[i] = 0 t.table[i] = 0
end end
-- scan symbol lengths, and sum code length counts -- scan symbol lengths, and sum code length counts
for i = 0, num - 1 do for i = 0, num - 1 do
t.table[lengths[off + i]] += 1 t.table[lengths[off + i]] += 1
end end
t.table[0] = 0 t.table[0] = 0
-- compute offset table for distribution sort -- compute offset table for distribution sort
local sum = 0 local sum = 0
for i = 0, 15 do for i = 0, 15 do
offs[i] = sum offs[i] = sum
sum = sum + t.table[i] sum += t.table[i]
end end
-- create code->symbol translation table -- create code->symbol translation table
for i = 0, num - 1 do for i = 0, num - 1 do
local len = lengths[off + i] local len = lengths[off + i]
if len > 0 then if len > 0 then
t.trans[offs[len]] = i t.trans[offs[len]] = i
offs[len] += 1 offs[len] += 1
end end
end end
end end
local function getBit(d: Data): number local function getBit(d: Data): number
if d.bitcount <= 0 then if d.bitcount <= 0 then
d.tag = buffer.readu8(d.source, d.sourceIndex) d.tag = buffer.readu8(d.source, d.sourceIndex)
d.sourceIndex += 1 d.sourceIndex += 1
d.bitcount = 8 d.bitcount = 8
end end
local bit = bit32.band(d.tag, 1) local bit = bit32.band(d.tag, 1)
d.tag = bit32.rshift(d.tag, 1) d.tag = bit32.rshift(d.tag, 1)
d.bitcount -= 1 d.bitcount -= 1
return bit return bit
end end
local function readBits(d: Data, num: number?, base: number): number local function readBits(d: Data, num: number?, base: number): number
if not num then if not num then
return base return base
end end
while d.bitcount < 24 and d.sourceIndex < buffer.len(d.source) do while d.bitcount < 24 and d.sourceIndex < buffer.len(d.source) do
d.tag = bit32.bor(d.tag, bit32.lshift(buffer.readu8(d.source, d.sourceIndex), d.bitcount)) d.tag = bit32.bor(d.tag, bit32.lshift(buffer.readu8(d.source, d.sourceIndex), d.bitcount))
d.sourceIndex += 1 d.sourceIndex += 1
d.bitcount += 8 d.bitcount += 8
end end
local val = bit32.band(d.tag, bit32.rshift(0xffff, 16 - num)) local val = bit32.band(d.tag, bit32.rshift(0xffff, 16 - num))
d.tag = bit32.rshift(d.tag, num) d.tag = bit32.rshift(d.tag, num)
d.bitcount -= num d.bitcount -= num
return val + base return val + base
end end
local function decodeSymbol(d: Data, t: Tree): number local function decodeSymbol(d: Data, t: Tree): number
while d.bitcount < 24 and d.sourceIndex < buffer.len(d.source) do while d.bitcount < 24 and d.sourceIndex < buffer.len(d.source) do
d.tag = bit32.bor(d.tag, bit32.lshift(buffer.readu8(d.source, d.sourceIndex), d.bitcount)) d.tag = bit32.bor(d.tag, bit32.lshift(buffer.readu8(d.source, d.sourceIndex), d.bitcount))
d.sourceIndex += 1 d.sourceIndex += 1
d.bitcount += 8 d.bitcount += 8
end end
local sum, cur, len = 0, 0, 0 local sum, cur, len = 0, 0, 0
local tag = d.tag local tag = d.tag
repeat repeat
cur = 2 * cur + bit32.band(tag, 1) cur = 2 * cur + bit32.band(tag, 1)
tag = bit32.rshift(tag, 1) tag = bit32.rshift(tag, 1)
len += 1 len += 1
sum += t.table[len] sum += t.table[len]
cur -= t.table[len] cur -= t.table[len]
until cur < 0 until cur < 0
d.tag = tag d.tag = tag
d.bitcount -= len d.bitcount -= len
return t.trans[sum + cur] return t.trans[sum + cur]
end end
local function decodeTrees(d: Data, lengthTree: Tree, distTree: Tree) local function decodeTrees(d: Data, lengthTree: Tree, distTree: Tree)
local hlit = readBits(d, 5, 257) local hlit = readBits(d, 5, 257)
local hdist = readBits(d, 5, 1) local hdist = readBits(d, 5, 1)
local hclen = readBits(d, 4, 4) local hclen = readBits(d, 4, 4)
for i = 0, 18 do for i = 0, 18 do
lengths[i] = 0 lengths[i] = 0
end end
for i = 0, hclen - 1 do for i = 0, hclen - 1 do
lengths[clcIndex[i + 1]] = readBits(d, 3, 0) lengths[clcIndex[i + 1]] = readBits(d, 3, 0)
end end
buildTree(codeTree, lengths, 0, 19) buildTree(codeTree, lengths, 0, 19)
local num = 0 local num = 0
while num < hlit + hdist do while num < hlit + hdist do
local sym = decodeSymbol(d, codeTree) local sym = decodeSymbol(d, codeTree)
if sym == 16 then if sym == 16 then
local prev = lengths[num - 1] local prev = lengths[num - 1]
for _ = 1, readBits(d, 2, 3) do for _ = 1, readBits(d, 2, 3) do
lengths[num] = prev lengths[num] = prev
num += 1 num += 1
end end
elseif sym == 17 then elseif sym == 17 then
for _ = 1, readBits(d, 3, 3) do for _ = 1, readBits(d, 3, 3) do
lengths[num] = 0 lengths[num] = 0
num += 1 num += 1
end end
elseif sym == 18 then elseif sym == 18 then
for _ = 1, readBits(d, 7, 11) do for _ = 1, readBits(d, 7, 11) do
lengths[num] = 0 lengths[num] = 0
num += 1 num += 1
end end
else else
lengths[num] = sym lengths[num] = sym
num += 1 num += 1
end end
end end
buildTree(lengthTree, lengths, 0, hlit) buildTree(lengthTree, lengths, 0, hlit)
buildTree(distTree, lengths, hlit, hdist) buildTree(distTree, lengths, hlit, hdist)
end end
local function inflateBlockData(d: Data, lengthTree: Tree, distTree: Tree) local function inflateBlockData(d: Data, lengthTree: Tree, distTree: Tree)
while true do while true do
local sym = decodeSymbol(d, lengthTree) local sym = decodeSymbol(d, lengthTree)
if sym == 256 then if sym == 256 then
return return
end end
if sym < 256 then if sym < 256 then
buffer.writeu8(d.dest, d.destLen, sym) buffer.writeu8(d.dest, d.destLen, sym)
d.destLen += 1 d.destLen += 1
else else
sym -= 257 sym -= 257
local length = readBits(d, lengthBits[sym], lengthBase[sym]) local length = readBits(d, lengthBits[sym], lengthBase[sym])
local dist = decodeSymbol(d, distTree) local dist = decodeSymbol(d, distTree)
local offs = d.destLen - readBits(d, distBits[dist], distBase[dist]) local offs = d.destLen - readBits(d, distBits[dist], distBase[dist])
for i = offs, offs + length - 1 do for i = offs, offs + length - 1 do
buffer.writeu8(d.dest, d.destLen, buffer.readu8(d.dest, i)) buffer.writeu8(d.dest, d.destLen, buffer.readu8(d.dest, i))
d.destLen += 1 d.destLen += 1
end end
end end
end end
end end
local function inflateUncompressedBlock(d: Data) local function inflateUncompressedBlock(d: Data)
while d.bitcount > 8 do while d.bitcount > 8 do
d.sourceIndex -= 1 d.sourceIndex -= 1
d.bitcount -= 8 d.bitcount -= 8
end end
local length = buffer.readu8(d.source, d.sourceIndex + 1) local length = buffer.readu8(d.source, d.sourceIndex + 1)
length = 256 * length + buffer.readu8(d.source, d.sourceIndex) length = 256 * length + buffer.readu8(d.source, d.sourceIndex)
local invlength = buffer.readu8(d.source, d.sourceIndex + 3) local invlength = buffer.readu8(d.source, d.sourceIndex + 3)
invlength = 256 * invlength + buffer.readu8(d.source, d.sourceIndex + 2) invlength = 256 * invlength + buffer.readu8(d.source, d.sourceIndex + 2)
if length ~= bit32.bxor(invlength, 0xffff) then if length ~= bit32.bxor(invlength, 0xffff) then
error("Invalid block length") error("Invalid block length")
end end
d.sourceIndex += 4 d.sourceIndex += 4
for _ = 1, length do for _ = 1, length do
buffer.writeu8(d.dest, d.destLen, buffer.readu8(d.source, d.sourceIndex)) buffer.writeu8(d.dest, d.destLen, buffer.readu8(d.source, d.sourceIndex))
d.destLen += 1 d.destLen += 1
d.sourceIndex += 1 d.sourceIndex += 1
end end
d.bitcount = 0 d.bitcount = 0
end end
local function uncompress(source: buffer): buffer local function uncompress(source: buffer): buffer
local dest = buffer.create(buffer.len(source) * 4) local dest = buffer.create(buffer.len(source) * 4)
local d = Data.new(source, dest) local d = Data.new(source, dest)
repeat repeat
local bfinal = getBit(d) local bfinal = getBit(d)
local btype = readBits(d, 2, 0) local btype = readBits(d, 2, 0)
if btype == 0 then if btype == 0 then
inflateUncompressedBlock(d) inflateUncompressedBlock(d)
elseif btype == 1 then elseif btype == 1 then
inflateBlockData(d, staticLengthTree, staticDistTree) inflateBlockData(d, staticLengthTree, staticDistTree)
elseif btype == 2 then elseif btype == 2 then
decodeTrees(d, d.ltree, d.dtree) decodeTrees(d, d.ltree, d.dtree)
inflateBlockData(d, d.ltree, d.dtree) inflateBlockData(d, d.ltree, d.dtree)
else else
error("Invalid block type") error("Invalid block type")
end end
until bfinal == 1 until bfinal == 1
if d.destLen < buffer.len(dest) then if d.destLen < buffer.len(dest) then
local result = buffer.create(d.destLen) local result = buffer.create(d.destLen)
buffer.copy(result, 0, dest, 0, d.destLen) buffer.copy(result, 0, dest, 0, d.destLen)
return result return result
end end
return dest return dest
end end
-- Initialize static trees and tables -- Initialize static trees and tables

View file

@ -127,7 +127,7 @@ function ZipReader.parseCentralDirectory(self: ZipReader): ()
if buffer.readu32(self.data, pos) == SIGNATURES.END_OF_CENTRAL_DIR then if buffer.readu32(self.data, pos) == SIGNATURES.END_OF_CENTRAL_DIR then
break break
end end
pos = pos - 1 pos -= 1
end end
-- Central Directory offset is stored 16 bytes into the EoCD record -- Central Directory offset is stored 16 bytes into the EoCD record
@ -373,12 +373,12 @@ function ZipReader.getStats(self: ZipReader): ZipStatistics
-- Iterate through the entries, updating stats -- Iterate through the entries, updating stats
for _, entry in self.entries do for _, entry in self.entries do
if entry.isDirectory then if entry.isDirectory then
stats.dirCount = stats.dirCount + 1 stats.dirCount += 1
continue continue
end end
stats.fileCount = stats.fileCount + 1 stats.fileCount += 1
stats.totalSize = stats.totalSize + entry.size stats.totalSize += entry.size
end end
return stats return stats