57 commits

Author	SHA1	Message	Date
Luka	c6e5b5932c	fix(lib): hanging after tool installation (#5) ... Fixes an issue where the process sometimes hangs indefinitely after installation of a tool. This is done by removing the usage of `task.cancel` within the code for progress bars, and instead checking the `finished` value within the task.	2025-02-12 21:41:11 +05:30
daimond113	95712bc820	fix: prevent deadlock in concurrent installs ... Previously, the code tried to acquire a lock every 1s while checking if it exists. This caused a deadlock, since the lock got acquired by the concurrent process after the installation had completed and the lock was released.	2025-02-08 01:12:09 +01:00
Erica Marigold	d27a895e67	refactor(lib): restructure locking mechanism to be atomic ... Fixes a potential TOCTOU bug in the locking mechanism by restructuring and using file moves which are atomic on both windows and unix. FIXME: This commit introduces a bug where if there is are two concurrent processes attempting to install a tool such that the tool has artifact naming patterns that we understand (and hence do not need to download every artifact for), the parent installation process (i.e., the one which started first) yields indefinitely even after installing and running the tool.	2025-02-05 13:57:22 +05:30
Erica Marigold	283db5df4a	fix(lib): write progress bar cleanup ANSI sequences to stderr	2025-02-05 13:31:52 +05:30
Erica Marigold	61c20b25a3	feat(lib): upgrade pathfs and dirs to v0.3.0	2025-02-05 12:30:00 +05:30
Erica Marigold	78577110cf	fix(lib): use expiration time units in seconds ... `os.time()` returns a timestamp in seconds, not milliseconds, but the expiration time was adding 60,000 assuming it was in milliseconds. This has now been corrected to only add 60 in seconds.	2025-02-05 12:11:10 +05:30
Erica Marigold	6342b5ca87	feat(lib): write progress bars to stderr	2025-01-22 12:25:16 +05:30
Erica Marigold	13cae3a375	feat(lib): make it possible to override interactivity state externally ... Libraries that depend on toolchainlib can now set `_G.interactive` manually and have that option be respected.	2025-01-22 12:16:20 +05:30
Erica Marigold	c85c895408	fix(lib): only attempt to clear current progress bar if interactive	2025-01-22 12:11:53 +05:30
Erica Marigold	1ae6570d8a	refactor(lib): update installation lock related comments	2025-01-21 22:46:09 +05:30
Erica Marigold	aef778883e	feat(lib): use structured lock file with metadata ... This allows for us to know whether a lock file is too old and hence invalid, and perform a sanity check to ensure that the resource it is meant to be protecting is the resource we are trying to access.	2025-01-21 22:39:07 +05:30
Erica Marigold	57605e87b8	refactor(lib): use declared tool dir and use assert to handle nil	2025-01-21 22:19:56 +05:30
Erica Marigold	8cea7bef8a	fix(lib): fix directory checking condition for tool dir creation	2025-01-21 22:18:42 +05:30
Erica Marigold	3757ee3583	fix(lib): make installation lock be tool scoped ... Instead of having a global installation lock be held in the tool storage dir, it is now held on a per-tool basis within the tool's directory.	2025-01-21 22:15:56 +05:30
Erica Marigold	295023129f	fix(lib): hold on-disk lock for installation attempts ... * Fixes an issue to do with multiple installation attempts trying to access the same resources concurrently, causing installation errors * Made conditional progress bar a shared state among `__call` metamethod shorthand and `installTool`, in order to prevent constructing it in two different places	2025-01-21 16:29:09 +05:30
Erica Marigold	14860284da	fix(lib): windows PE format detection offset being a u32	2025-01-16 08:48:48 +00:00
Erica Marigold	f4f05b8264	fix(lib): TypeError in extractEntry function for zip	2025-01-16 08:48:03 +00:00
Luka	3e1876ad43	feat(lib): switch to luau-unzip (#3) ... * chore(bins): bump `asphalt` to v0.8.4 * chore(bins): bump `selene` to v0.28.0 * feat(lib): use luau-unzip * chore(CHANGELOG): add luau-unzip * chore: switch back to CRLF * fix(lib): extracting wrong binary * refactor(lib): use extractEntry function * refactor(lib): make checks explicit and add comments to zip decompressor * chore(lib): remove unused exec util * chore(CHANGELOG): remove trailing full-stop --------- Co-authored-by: Erica Marigold <hi@devcomp.xyz>	2025-01-16 13:08:06 +05:30
Erica Marigold	472813b41b	style: apply stylua formatter	2024-12-25 16:11:05 +00:00
Erica Marigold	ed8d5594b9	fix(lib): unhandled error when no gh CLI present ... We did not correctly handle the case if the `gh` CLI was not present, since `process.spawn` errors. We now wrap it in a `Result.try` and handle that as required.	2024-12-25 15:56:39 +00:00
Erica Marigold	aba182cea5	fix(lib): handle result conditionally too ... Previously, we were calling `:unwrap` while trying to increment the progress bar even if we were not in an interactive environment. This fixes that.	2024-12-25 15:48:50 +00:00
Erica Marigold	773cc1b2a1	fix(lib): error while attempting to migrate when new dir exists	2024-12-22 15:59:27 +00:00
Erica Marigold	76e434ec6d	fix(lib): propagate ProgressBar results and handle them	2024-12-22 15:58:52 +00:00
Erica Marigold	7bf8063366	feat(lib): make ProgressBar:nextStage return a result	2024-12-16 19:28:28 +00:00
Erica Marigold	e0a9ca9aa4	fix(lib)!: check if existing tool_storage is dir, not file	2024-12-16 07:28:26 +00:00
Erica Marigold	9a3f3717de	feat(lib): address type related FIXMEs	2024-12-14 06:18:40 +00:00
Erica Marigold	bb6278407d	feat(lib): use gh CLI to get token and condition bar start ... * Looks for `$GITHUB_TOKEN` env var, and if not found, tries to run `gh auth token` to get the token from the GitHub CLI. * Made a conditional `start` method for the bar, which was previously missed.	2024-12-14 06:13:17 +00:00
Erica Marigold	0726169df8	feat(lib): rename tool_storage dir ... Tools are now stored in the `~/.pesde/bin/.tool_storage` directory, in order to prevent naming conflicts with other tool linkers. An old tool_storage directory gets migrated to the new path if present.	2024-12-13 18:20:29 +00:00
Erica Marigold	202dc85147	feat(lib): add a touch of color to progress bar ... Also moves bar stopping logic for errors into pcall handler.	2024-12-13 18:04:42 +00:00
Erica Marigold	2f79159f95	fix(lib): progress bar interfering with warns ... * Fixed overlapping warns and progress bar. * Removed unnecessary `resume` and `stop` bar methods.	2024-12-13 17:52:28 +00:00
Erica Marigold	f377116271	refactor(lib): minor structure improvements for progress bar ... * Made bar related conditional operations get constructed by a `makeCondBar` which returns a table of functions to conditionally handle a progress bar. * Moved progress bar boolean out of function args for `installTool` into global state.	2024-12-13 16:34:36 +00:00
Erica Marigold	c69a7417a0	feat(lib): include optional progress bar ... Includes an optional progress bar which gets enabled when lib is called using the default convenience `__call` metamethod.	2024-12-13 16:25:42 +00:00
Erica Marigold	ead60c003e	refactor(lib): use extension pattern for result<->option ... Formerly, we used metatables to get custom `Option` and `Result` objects which were difficult to type properly, leading to a lot of `unknown` and `any` casts. This refactor fixes it by making extensions opt-in, where we import the extension methods separately from the original implementations, thereby allowing us to not have to typecast things everywhere.	2024-12-13 14:33:05 +00:00
Erica Marigold	45627ea4a9	feat(lib): only download asset when it is of a valid format ... Small optimization to not fetch an asset if its need of a supported compression format.	2024-12-13 13:51:38 +00:00
Erica Marigold	940ceea50f	style: apply stylua formatter	2024-12-09 04:43:15 +00:00
Erica Marigold	80882fc173	feat(lib): remove reliance on semver parsing ... Previously, we assumed that the tools followed semver, and hence parsed their versions for comparison. Some tools may not follow semver, and we should not impose such a requirement as a toolchain management library. Therefore, we now only check if the requested version string matches an asset version tag. In order to ensure backwards compatibility, we strip the leading `v` from the version if present.	2024-12-09 03:34:05 +00:00
Erica Marigold	e46bb0f3ca	feat(lib): make manifest decoding and access type-safe ... Includes types to describe the shape of a pesde manifest and its components.	2024-12-01 12:15:57 +00:00
Erica Marigold	cca939e355	fix(lib): remove duplicate version defaulting code	2024-12-01 05:35:58 +00:00
Erica Marigold	97cc64bc81	fix(lib): don't panic on bad descriptor for binary	2024-12-01 05:34:29 +00:00
Erica Marigold	5b1a25bd53	feat(lib): relocate GithubReleases type and implement custom payload ... * Also breaks down `GithubReleases` into array of `GithubRelease` type * Adds a `Custom` operation type for internal `Github` class, allowing user to mention custom request data	2024-11-30 18:29:36 +00:00
Erica Marigold	828339feaa	fix(lib): fix exec detection fallthrough ... If the executable was invalid, and wasn't PE or ELF, it would fall through into the Mach-O case, which was a false positive.	2024-11-28 17:48:57 +00:00
Erica Marigold	e396b070c5	fix(lib): bad chmod mode value ... In this previous commit, it was setting mode to base-10 755, which is equivalent to octal 1363, being an invalid mode.	2024-11-28 16:31:20 +00:00
Erica Marigold	8cf8d8e916	feat(lib): use different tool_storage structure, chmod on unix ... * Fix for tools which don't already provide zips with binaries that have their executable bit set, by executing chmod before attempting to run. * Uses a different tool_storage structure to prevent changing the tool name and causing confusion for tools which change their help menu binary name based on the current exe name.	2024-11-28 16:08:15 +00:00
Erica Marigold	cf3bac5d41	revert: Expand-Archive cmdlet displaying prog ... Reverts 694430b768.	2024-11-25 12:04:22 +00:00
Erica Marigold	5ff9e8b7c5	fix(lib): Expand-Archive cmdlet displaying prog	2024-11-25 11:55:47 +00:00
Erica Marigold	21c4a0b9cf	style: apply formatting to all files	2024-11-25 11:47:56 +00:00
Erica Marigold	ca881272be	fix(lib): forward pwsh stdout on windows debug	2024-11-25 11:45:07 +00:00
Erica Marigold	95afc33630	fix(lib): bad argument to Start-Process cmdlet	2024-11-25 11:43:15 +00:00
Erica Marigold	3a65776a3c	fix(lib): decompression on windows ... * Decompression on windows failed since the `Start-Process` cmdlet exited immediately after spawning the process. Fixed by including the `-Wait` argument. * We were using `unzip` on all platforms, and it does not exist on Windows. Instead, now we use the `Expand-Archive` cmdlet for decompression on windows.	2024-11-25 11:24:18 +00:00
Erica Marigold	b6f75cbda9	fix(lib): binary descriptor fallback not matching ... * Fixes a bug which caused binary parsing fallbacks to not work as expected, due to a field unexpectedly being `None`. * Fixed lint error to do with warn being potentially none by defining our own warn function instead. Also updated fallback binary parsing fallback warn message to be clearer. * Fixed decompression error for non-supported artifacts by only decompressing those we support.	2024-11-25 08:10:05 +00:00