feat: keep dev dependencies in manifest file

registry/src/endpoints/publish_version.rs

@@ -11,8 +11,16 @@ use git2::{Remote, Repository, Signature};
 use rusty_s3::{actions::PutObject, S3Action};
 use tar::Archive;
 
+use crate::{
+    auth::UserId,
+    benv,
+    error::{Error, ErrorResponse},
+    package::{s3_name, S3_SIGN_DURATION},
+    search::update_version,
+    AppState,
+};
 use pesde::{
-    manifest::Manifest,
+    manifest::{DependencyType, Manifest},
     source::{
         git_index::GitBasedSource,
         pesde::{IndexFile, IndexFileEntry, ScopeInfo, SCOPE_INFO_FILE},
@@ -23,15 +31,6 @@ use pesde::{
     MANIFEST_FILE_NAME,
 };
 
-use crate::{
-    auth::UserId,
-    benv,
-    error::{Error, ErrorResponse},
-    package::{s3_name, S3_SIGN_DURATION},
-    search::update_version,
-    AppState,
-};
-
 fn signature<'a>() -> Signature<'a> {
     Signature::now(
         &benv!(required "COMMITTER_GIT_NAME"),
@@ -122,10 +121,10 @@ pub async fn publish_package(
 
         let dependencies = manifest
             .all_dependencies()
-            .map_err(|_| Error::InvalidArchive)?;
+            .map_err(|_| Error::InvalidArchive)?
-
+            .into_iter()
-        for (specifier, _) in dependencies.values() {
+            .filter_map(|(alias, (specifier, ty))| {
-            match specifier {
+                match &specifier {
                     DependencySpecifiers::Pesde(specifier) => {
                         if specifier
                             .index
@@ -137,20 +136,19 @@ pub async fn publish_package(
                             })
                             .is_none()
                         {
-                        return Err(Error::InvalidArchive);
+                            return Some(Err(Error::InvalidArchive));
                         }
 
                         let (dep_scope, dep_name) = specifier.name.as_str();
-                    if source
+                        match source.read_file([dep_scope, dep_name], &app_state.project, None) {
-                        .read_file([dep_scope, dep_name], &app_state.project, None)?
+                            Ok(Some(_)) => {}
-                        .is_none()
+                            Ok(None) => return Some(Err(Error::InvalidArchive)),
-                    {
+                            Err(e) => return Some(Err(e.into())),
-                        return Err(Error::InvalidArchive);
                         }
                     }
                     DependencySpecifiers::Wally(specifier) => {
                         if !config.wally_allowed {
-                        return Err(Error::InvalidArchive);
+                            return Some(Err(Error::InvalidArchive));
                         }
 
                         if specifier
@@ -159,17 +157,24 @@ pub async fn publish_package(
                             .filter(|index| index.parse::<url::Url>().is_ok())
                             .is_none()
                         {
-                        return Err(Error::InvalidArchive);
+                            return Some(Err(Error::InvalidArchive));
                         }
                     }
                     DependencySpecifiers::Git(_) => {
                         if !config.git_allowed {
-                        return Err(Error::InvalidArchive);
+                            return Some(Err(Error::InvalidArchive));
                         }
                     }
                 };
+
+                if ty == DependencyType::Dev {
+                    return None;
                 }
 
+                Some(Ok((alias, (specifier, ty))))
+            })
+            .collect::<Result<_, Error>>()?;
+
         let repo = source.repo_git2(&app_state.project)?;
 
         let (scope, name) = manifest.name.as_str();

src/manifest/mod.rs

@@ -82,7 +82,7 @@ pub struct Manifest {
     #[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
     pub peer_dependencies: BTreeMap<String, DependencySpecifiers>,
     /// The dev dependencies of the package
-    #[serde(default, skip_serializing)]
+    #[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
     pub dev_dependencies: BTreeMap<String, DependencySpecifiers>,
 }