fix: fix double long prefix paths on windows

Our previous attempt at fixing the long path issue
on Windows has caused a regression. This commit
attempts to fix both issues by simply
canonicalizing the path.

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+### Fixed
+- Fix double path long prefix issues on Windows by @daimond113
+
 ## [0.6.0-rc.5] - 2025-02-10
 ### Fixed
 - Correct script linker require paths on Windows by @daimond113

src/linking/mod.rs

@@ -166,6 +166,8 @@ impl Project {
 		package_types: &Arc<PackageTypes>,
 		is_complete: bool,
 	) -> Result<(), errors::LinkingError> {
+		let package_dir_canonical = fs::canonicalize(self.package_dir()).await?;
+
 		let mut tasks = JoinSet::<Result<_, errors::LinkingError>>::new();
 		let mut link_files = |base_folder: &Path,
 		                      container_folder: &Path,
@@ -224,8 +226,7 @@ impl Project {
 				.scripts()
 				.filter(|s| !s.is_empty() && node.node.direct.is_some() && is_root)
 			{
-				let scripts_base = self
-					.package_dir()
+				let scripts_base = package_dir_canonical
 					.join(SCRIPTS_LINK_FOLDER)
 					.join(alias.as_str());
 

src/main.rs

@@ -135,23 +135,8 @@ impl<'a> MakeWriter<'a> for IndicatifWriter {
 	}
 }
 
-#[cfg(windows)]
-fn long_path_prefix(path: PathBuf) -> PathBuf {
-	if path.starts_with(r"\\?\") {
-		path
-	} else {
-		let mut str = std::ffi::OsString::from(r"\\?\");
-		str.push(path.into_os_string());
-		str.into()
-	}
-}
-
 async fn run() -> anyhow::Result<()> {
 	let cwd = std::env::current_dir().expect("failed to get current working directory");
-	// pathdiff doesn't work properly when diffing paths with and without long path prefixes
-	// so, we'll try to use the long path prefix where ever possible
-	#[cfg(windows)]
-	let cwd = long_path_prefix(cwd);
 	// Unix doesn't return the symlinked path, so we need to get it from the 0 argument
 	#[cfg(unix)]
 	let current_exe = PathBuf::from(std::env::args_os().next().expect("argument 0 not set"));