From c0b2e1e14e3c5eb1d37d5a70c7015c877427104e Mon Sep 17 00:00:00 2001 From: Stefan <42220813+Stefanuk12@users.noreply.github.com> Date: Thu, 24 Apr 2025 20:14:18 +0100 Subject: [PATCH 1/3] fix: remove arc Co-authored-by: dai --- src/download_and_link.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/download_and_link.rs b/src/download_and_link.rs index 665bf9b..780b3d9 100644 --- a/src/download_and_link.rs +++ b/src/download_and_link.rs @@ -479,7 +479,6 @@ impl Project { .map_err(errors::DownloadAndLinkError::Hook)?; } - let graph = Arc::into_inner(graph).unwrap(); if install_dependencies_mode != InstallDependenciesMode::All || !force { self.remove_unused(&graph).await?; From 889e5611bbcb017f4e9e5a41ffab47ee8f51daba Mon Sep 17 00:00:00 2001 From: Stefan <42220813+Stefanuk12@users.noreply.github.com> Date: Thu, 24 Apr 2025 21:43:01 +0100 Subject: [PATCH 2/3] chore: grammar fixes Co-authored-by: dai --- src/download_and_link.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/download_and_link.rs b/src/download_and_link.rs index 780b3d9..e476249 100644 --- a/src/download_and_link.rs +++ b/src/download_and_link.rs @@ -279,8 +279,8 @@ impl Project { return Some(make_fut(id, node, container_folder)); } - // not a direct dependency, check if it's parent is and matches the install mode - // todo: optimise this maybe. many iterations through graph can add up if graph big + // not a direct dependency, check if its parent is and matches the install mode + // TODO: optimise this maybe. many iterations through the graph can add up if the graph's big let mut current_parent = &id; while let Some((parent_id, parent_node)) = From d0569ac16dd2fd6d77dd100cbfd8949c39fdbf26 Mon Sep 17 00:00:00 2001 From: Stefan <42220813+Stefanuk12@users.noreply.github.com> Date: Thu, 24 Apr 2025 21:43:36 +0100 Subject: [PATCH 3/3] chore: remove eagerly implemented traits Co-authored-by: dai --- src/download_and_link.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/download_and_link.rs b/src/download_and_link.rs index e476249..3553de1 100644 --- a/src/download_and_link.rs +++ b/src/download_and_link.rs @@ -66,10 +66,9 @@ impl DownloadAndLinkHooks for () { } /// Options for which dependencies to install. -#[derive(Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Debug, Default)] +#[derive(Debug, Clone, Copy, PartialEq, Eq)] pub enum InstallDependenciesMode { /// Install all dependencies. - #[default] All, /// Install only dependencies, not dev_dependencies. Prod,