pesde-pkg/pesde
1
1
Fork 0
mirror of https://github.com/pesde-pkg/pesde.git synced 2025-04-05 11:20:55 +01:00
Code Issues Projects Releases Packages Wiki Activity

perf: lazily format error messages
Some checks are pending
Debug / Get build version (push) Waiting to run
Debug / Build for linux-x86_64 (push) Blocked by required conditions
Debug / Build for macos-aarch64 (push) Blocked by required conditions
Debug / Build for macos-x86_64 (push) Blocked by required conditions
Debug / Build for windows-x86_64 (push) Blocked by required conditions
Test & Lint / lint (push) Waiting to run

Browse source
This commit is contained in:
daimond113 2024-12-28 18:13:53 +01:00
parent a091d06f36
commit aabb353d25
No known key found for this signature in database
GPG key ID: 3A8ECE51328B513C
3 changed files with 17 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG.md
View file

@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Performance ### Performance
- Use `Arc` for more efficient cloning of multiple structs by @daimond113 - Use `Arc` for more efficient cloning of multiple structs by @daimond113
- Avoid cloning where possible by @daimond113 - Avoid cloning where possible by @daimond113
- Remove unnecessary mutex in Wally package download by @daimond113
- Lazily format error messages by @daimond113
## [0.5.2] - 2024-12-19 ## [0.5.2] - 2024-12-19
### Fixed ### Fixed

2
src/cli/commands/outdated.rs
View file

@ -96,7 +96,7 @@ impl OutdatedCommand {
.1 .1
.pop_last() .pop_last()
.map(|(v_id, _)| v_id) .map(|(v_id, _)| v_id)
.context(format!("no versions of {specifier} found"))?; .with_context(|| format!("no versions of {specifier} found"))?;
if version_id != current_version_id { if version_id != current_version_id {
println!( println!(

24
src/cli/commands/publish.rs
View file

@ -224,7 +224,7 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
let export_path = export_path let export_path = export_path
.canonicalize() .canonicalize()
.context(format!("failed to canonicalize {name}"))?; .with_context(|| format!("failed to canonicalize {name}"))?;
if let Err(err) = full_moon::parse(&contents).map_err(|errs| { if let Err(err) = full_moon::parse(&contents).map_err(|errs| {
errs.into_iter() errs.into_iter()
@ -238,7 +238,7 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
let first_part = relative_export_path let first_part = relative_export_path
.components() .components()
.next() .next()
.context(format!("{name} must contain at least one part"))?; .with_context(|| format!("{name} must contain at least one part"))?;
let first_part = match first_part { let first_part = match first_part {
relative_path::Component::Normal(part) => part, relative_path::Component::Normal(part) => part,
@ -316,7 +316,7 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
let script_path = script_path let script_path = script_path
.canonicalize() .canonicalize()
.context(format!("failed to canonicalize script {name}"))?; .with_context(|| format!("failed to canonicalize script {name}"))?;
if let Err(err) = full_moon::parse(&contents).map_err(|errs| { if let Err(err) = full_moon::parse(&contents).map_err(|errs| {
errs.into_iter() errs.into_iter()
@ -365,7 +365,9 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
&relative_path, &relative_path,
fs::File::open(&path) fs::File::open(&path)
.await .await
.context(format!("failed to read `{}`", relative_path.display()))? .with_context(|| {
format!("failed to read `{}`", relative_path.display())
})?
.file_mut(), .file_mut(),
) )
.await?; .await?;
@ -391,7 +393,9 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
manifest manifest
.indices .indices
.get(&index_name) .get(&index_name)
.context(format!("index {index_name} not found in indices field"))? .with_context(|| {
format!("index {index_name} not found in indices field")
})?
.to_string(), .to_string(),
); );
} }
@ -406,9 +410,9 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
manifest manifest
.wally_indices .wally_indices
.get(&index_name) .get(&index_name)
.context(format!( .with_context(|| {
"index {index_name} not found in wally_indices field" format!("index {index_name} not found in wally_indices field")
))? })?
.to_string(), .to_string(),
); );
} }
@ -452,7 +456,7 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
} }
VersionTypeOrReq::Req(r) => r, VersionTypeOrReq::Req(r) => r,
v => VersionReq::parse(&format!("{v}{}", manifest.version)) v => VersionReq::parse(&format!("{v}{}", manifest.version))
.context(format!("failed to parse version for {v}"))?, .with_context(|| format!("failed to parse version for {v}"))?,
}, },
index: Some( index: Some(
manifest manifest
@ -589,7 +593,7 @@ info: otherwise, the file was deemed unnecessary, if you don't understand why, p
let index_url = manifest let index_url = manifest
.indices .indices
.get(&self.index) .get(&self.index)
.context(format!("missing index {}", self.index))?; .with_context(|| format!("missing index {}", self.index))?;
let source = PesdePackageSource::new(index_url.clone()); let source = PesdePackageSource::new(index_url.clone());
refreshed_sources refreshed_sources
.refresh( .refresh(