From 6ab334c9043b3bfbd0961729f37d8128d9049f6b Mon Sep 17 00:00:00 2001
From: daimond113 <72147841+daimond113@users.noreply.github.com>
Date: Thu, 9 Jan 2025 23:04:06 +0100
Subject: [PATCH] feat: use url encoding crate to ensure validity of urls

---
 CHANGELOG.md            | 1 +
 src/source/pesde/mod.rs | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6719a5e..d5adf87 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Change handling of graphs to a flat structure by @daimond113
 - Store dependency over downloaded graphs in the lockfile by @daimond113
 - Improve linking process by @daimond113
+- Use a proper url encoding library to ensure compatibility with all characters by @daimond113
 
 ### Removed
 - Remove old includes format compatibility by @daimond113
diff --git a/src/source/pesde/mod.rs b/src/source/pesde/mod.rs
index a1c41bf..321b3fa 100644
--- a/src/source/pesde/mod.rs
+++ b/src/source/pesde/mod.rs
@@ -210,9 +210,9 @@ impl PackageSource for PesdePackageSource {
 
 		let url = config
 			.download()
-			.replace("{PACKAGE}", &id.name().to_string().replace("/", "%2F"))
-			.replace("{PACKAGE_VERSION}", &id.version_id().version().to_string())
-			.replace("{PACKAGE_TARGET}", &id.version_id().target().to_string());
+			.replace("{PACKAGE}", &urlencoding::encode(&id.name().to_string()))
+			.replace("{PACKAGE_VERSION}", &urlencoding::encode(&id.version_id().version().to_string()))
+			.replace("{PACKAGE_TARGET}", &urlencoding::encode(&id.version_id().target().to_string()));
 
 		let mut request = reqwest.get(&url).header(ACCEPT, "application/octet-stream");