From 43a8d6272aac4ad572c7fe905477365af68b11ad Mon Sep 17 00:00:00 2001 From: daimond113 <72147841+daimond113@users.noreply.github.com> Date: Sat, 12 Oct 2024 18:59:57 +0200 Subject: [PATCH] fix: remove duplicate manifest name in publish command --- CHANGELOG.md | 3 ++- src/cli/commands/publish.rs | 4 +--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f70f6d4..24c35f5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Fixed - Fix `self-upgrade` overwriting its own binary by @daimond113 -- Allow use of Luau packages in `execute` command by @daimond113 +- Allow use of Luau packages in `execute` command by @daimond113 +- Remove duplicated manifest file name in `publish` command by @daimond113 ## [0.5.0-rc.4] - 2024-10-12 ### Added diff --git a/src/cli/commands/publish.rs b/src/cli/commands/publish.rs index 28cccc4..23657f4 100644 --- a/src/cli/commands/publish.rs +++ b/src/cli/commands/publish.rs @@ -107,8 +107,6 @@ impl PublishCommand { }; if !manifest.includes.insert(MANIFEST_FILE_NAME.to_string()) { - display_includes.push(MANIFEST_FILE_NAME.to_string()); - println!( "{}: {MANIFEST_FILE_NAME} was not in includes, adding it", "warn".yellow().bold() @@ -224,7 +222,7 @@ impl PublishCommand { anyhow::bail!("included file {included_name} does not exist"); } - // it'll be included later, with our mut modifications + // it's already included, and guaranteed to be a file if included_name.eq_ignore_ascii_case(MANIFEST_FILE_NAME) { continue; }