Clean up LuneError type for consumers

src/lune/error.rs

@@ -12,35 +12,72 @@ use crate::lune::lua::stdio::formatting::pretty_format_luau_error;
 */
 #[derive(Debug, Clone)]
 pub struct LuneError {
-    message: String,
+    error: LuaError,
-    incomplete_input: bool,
+    disable_colors: bool,
 }
 
 impl LuneError {
-    pub(crate) fn from_lua_error(error: LuaError, disable_colors: bool) -> Self {
+    /**
-        Self {
+        Enables colorization of the error message when formatted using the [`Display`] trait.
-            message: pretty_format_luau_error(&error, !disable_colors),
+
-            incomplete_input: matches!(
+        Colorization is enabled by default.
-                error,
+    */
-                LuaError::SyntaxError {
+    #[doc(hidden)]
-                    incomplete_input: true,
+    pub fn enable_colors(mut self) -> Self {
-                    ..
+        self.disable_colors = false;
-                }
+        self
-            ),
+    }
-        }
+
+    /**
+        Disables colorization of the error message when formatted using the [`Display`] trait.
+
+        Colorization is enabled by default.
+    */
+    #[doc(hidden)]
+    pub fn disable_colors(mut self) -> Self {
+        self.disable_colors = true;
+        self
+    }
+
+    /**
+        Returns `true` if the error can likely be fixed by appending more input to the source code.
+
+        See [`mlua::Error::SyntaxError`] for more information.
+    */
+    pub fn is_incomplete_input(&self) -> bool {
+        matches!(
+            self.error,
+            LuaError::SyntaxError {
+                incomplete_input: true,
+                ..
+            }
+        )
     }
 }
 
-impl LuneError {
+impl From<LuaError> for LuneError {
-    pub fn is_incomplete_input(&self) -> bool {
+    fn from(value: LuaError) -> Self {
-        self.incomplete_input
+        Self {
+            error: value,
+            disable_colors: false,
+        }
     }
 }
 
 impl Display for LuneError {
     fn fmt(&self, f: &mut Formatter<'_>) -> FmtResult {
-        write!(f, "{}", self.message)
+        write!(
+            f,
+            "{}",
+            pretty_format_luau_error(&self.error, !self.disable_colors)
+        )
     }
 }
 
-impl Error for LuneError {}
+impl Error for LuneError {
+    // TODO: Comment this out when we are ready to also re-export
+    // `mlua` as part of our public library interface in Lune
+    // fn cause(&self) -> Option<&dyn Error> {
+    //     Some(&self.error)
+    // }
+}

src/lune/mod.rs

@@ -56,7 +56,7 @@ impl Lune {
     ) -> Result<ExitCode, LuneError> {
         self.run_inner(script_name, script_contents)
             .await
-            .map_err(|err| LuneError::from_lua_error(err, false))
+            .map_err(LuneError::from)
     }
 
     async fn run_inner(
@@ -87,7 +87,7 @@ impl Lune {
                 loop {
                     let result = sched.resume_queue().await;
                     if let Some(err) = result.get_lua_error() {
-                        eprintln!("{}", LuneError::from_lua_error(err, false));
+                        eprintln!("{}", LuneError::from(err));
                         got_error = true;
                     }
                     if result.is_done() {