From 19e390995b1da0afc9605bdfb8e56d4cd8df5f6a Mon Sep 17 00:00:00 2001 From: Kenneth Loeffler Date: Fri, 7 Jul 2023 04:03:27 -0700 Subject: [PATCH] Use clone_into_external --- packages/lib-roblox/src/instance/mod.rs | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/lib-roblox/src/instance/mod.rs b/packages/lib-roblox/src/instance/mod.rs index ac63c1c..dfa16ab 100644 --- a/packages/lib-roblox/src/instance/mod.rs +++ b/packages/lib-roblox/src/instance/mod.rs @@ -140,18 +140,14 @@ impl Instance { root of the weak dom, and return its referent. */ pub fn clone_into_external_dom(self, external_dom: &mut WeakDom) -> DomRef { - let cloned = self.clone_instance(); - - let mut dom = INTERNAL_DOM + let dom = INTERNAL_DOM .try_write() .expect("Failed to get write access to document"); - let internal_dom_ref = cloned.dom_ref; - let external_root_ref = external_dom.root_ref(); + let cloned = dom.clone_into_external(self.dom_ref, external_dom); + external_dom.transfer_within(cloned, external_dom.root_ref()); - dom.transfer(internal_dom_ref, external_dom, external_root_ref); - - internal_dom_ref + cloned } /**