From 86e531e3a53e939be1343b9f226836dbbdd36ed8 Mon Sep 17 00:00:00 2001 From: Varun Saini <61795485+vrn-sn@users.noreply.github.com> Date: Thu, 12 Sep 2024 11:38:07 -0700 Subject: [PATCH] Link old implementations to these approaches --- docs/amended-alias-resolution.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/amended-alias-resolution.md b/docs/amended-alias-resolution.md index d8f0e98..3c291f1 100644 --- a/docs/amended-alias-resolution.md +++ b/docs/amended-alias-resolution.md @@ -12,10 +12,12 @@ In an [old RFC for require-by-string](https://github.com/luau-lang/luau/pull/969 the path `require("my/module")` is resolved by first checking if `my` is an alias defined in a `.luaurc` file. If so, we perform a string substitution on `my`. If not, we try to resolve `my/module` relative to the requiring file. +This is identical to approach (3a) below. This design changed in the next few months and became what we now have in [require-by-string-aliases.md](require-by-string-aliases.md): when requiring an alias, it must be prepended with the `@` prefix. Otherwise, we will assume the given string does not contain an alias and will resolve it relative to the requiring file. +This is identical to approach (1a) below. There have been disagreements about which approach is more appropriate, so this RFC will serve as a way to document the ongoing discussion and the final decision we make.