luau-lang/rfcs
1
0
Fork 0
mirror of https://github.com/luau-lang/rfcs.git synced 2025-05-04 10:43:48 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove references to ../

Browse source
This commit is contained in:
Varun Saini 2024-09-16 15:08:09 -07:00
parent e7c405681f
commit 4de80d39f0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/amended-alias-resolution.md
View file

@ -105,14 +105,14 @@ These approaches were deemed undesirable during discussion and are no longer bei
### (2) Strongly recommend explicit prefixes ### (2) Strongly recommend explicit prefixes
We don't make the `@`, `./`, or `../` prefixes necessary like in approach (1c), but we strongly recommend them. We don't make the `@` or `./` prefixes necessary like in approach (1c), but we strongly recommend them.
This can be accomplished by allowing unprefixed paths but throwing an error if they resolve to multiple files. This can be accomplished by allowing unprefixed paths but throwing an error if they resolve to multiple files.
There is a performance cost to this: currently, if we successfully match a given path to a file, we stop searching for other matches. There is a performance cost to this: currently, if we successfully match a given path to a file, we stop searching for other matches.
If this approach were implemented, we would need to search for at most two matching files in case we need to throw an error. If this approach were implemented, we would need to search for at most two matching files in case we need to throw an error.
In the case of multiple nested directories with their own `.luaurc` files and `paths` arrays, this search could take linear time with respect to the total number of paths defined, in the worst case. In the case of multiple nested directories with their own `.luaurc` files and `paths` arrays, this search could take linear time with respect to the total number of paths defined, in the worst case.
Of course, developers could use the `@`, `./`, or `../` prefixes to explicitly specify a search type and eliminate this performance cost. Of course, developers could use the `@` or `./` prefixes to explicitly specify a search type and eliminate this performance cost.
```luau ```luau
-- Error: ./libs/dependency.luau exists and .luaurc defines a distinct "libs" alias -- Error: ./libs/dependency.luau exists and .luaurc defines a distinct "libs" alias
-- Would require ./libs/dependency.luau if "libs" alias did not exist -- Would require ./libs/dependency.luau if "libs" alias did not exist