mirror of
https://github.com/luau-lang/luau.git
synced 2024-12-13 13:30:40 +00:00
76f67e0733
Type checker/autocomplete: * `Luau::autocomplete` no longer performs typechecking internally, make sure to run `Frontend::check` before performing autocomplete requests * Autocomplete string suggestions without "" are now only suggested inside the "" * Autocomplete suggestions now include `function (anonymous autofilled)` key with a full suggestion for the function expression (with arguments included) stored in `AutocompleteEntry::insertText` * `AutocompleteEntry::indexedWithSelf` is provided for function call suggestions made with `:` * Cyclic modules now see each other type exports as `any` to prevent memory use-after-free (similar to module return type) Runtime: * Updated inline/loop unroll cost model to better handle assignments (Fixes https://github.com/Roblox/luau/issues/978) * `math.noise` speed was improved by ~30% * `table.concat` speed was improved by ~5-7% * `tonumber` and `tostring` now have fastcall paths that execute ~1.5x and ~2.5x faster respectively (fixes #777) * Fixed crash in `luaL_typename` when index refers to a non-existing value * Fixed potential out of memory scenario when using `string.sub` or `string.char` in a loop * Fixed behavior of some fastcall builtins when called without arguments under -O2 to match original functions * Support for native code execution in VM is now enabled by default (note: native code still has to be generated explicitly) * `Codegen::compile` now accepts `CodeGen_OnlyNativeModules` flag. When set, only modules that have a `--!native` hot-comment at the top will be compiled to native code In our new typechecker: * Generic type packs are no longer considered to be variadic during unification * Timeout and cancellation now works in new solver * Fixed false positive errors around 'table' and 'function' type refinements * Table literals now use covariant unification rules. This is sound since literal has no type specified and has no aliases * Fixed issues with blocked types escaping the constraint solver * Fixed more places where error messages that should've been suppressed were still reported * Fixed errors when iterating over a top table type In our native code generation (jit): * 'DebugLuauAbortingChecks' flag is now supported on A64 * LOP_NEWCLOSURE has been translated to IR
369 lines
7.8 KiB
C++
369 lines
7.8 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
|
|
#include "Luau/AstQuery.h"
|
|
#include "Luau/BuiltinDefinitions.h"
|
|
#include "Luau/Scope.h"
|
|
#include "Luau/TypeInfer.h"
|
|
#include "Luau/Type.h"
|
|
#include "Luau/VisitType.h"
|
|
|
|
#include "Fixture.h"
|
|
|
|
#include "doctest.h"
|
|
|
|
using namespace Luau;
|
|
|
|
LUAU_FASTFLAG(DebugLuauDeferredConstraintResolution);
|
|
|
|
TEST_SUITE_BEGIN("TypeInferAnyError");
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "for_in_loop_iterator_returns_any")
|
|
{
|
|
CheckResult result = check(R"(
|
|
function bar(): any
|
|
return true
|
|
end
|
|
|
|
local a
|
|
for b in bar do
|
|
a = b
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ(builtinTypes->anyType, requireType("a"));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "for_in_loop_iterator_returns_any2")
|
|
{
|
|
CheckResult result = check(R"(
|
|
function bar(): any
|
|
return true
|
|
end
|
|
|
|
local a
|
|
for b in bar() do
|
|
a = b
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("any", toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "for_in_loop_iterator_is_any")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local bar: any
|
|
|
|
local a
|
|
for b in bar do
|
|
a = b
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("any", toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "for_in_loop_iterator_is_any2")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local bar: any
|
|
|
|
local a
|
|
for b in bar() do
|
|
a = b
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("any", toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "for_in_loop_iterator_is_error")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local a
|
|
for b in bar do
|
|
a = b
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
CHECK_EQ("*error-type*", toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "for_in_loop_iterator_is_error2")
|
|
{
|
|
CheckResult result = check(R"(
|
|
function bar(c) return c end
|
|
|
|
local a
|
|
for b in bar() do
|
|
a = b
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
CHECK_EQ("*error-type*", toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "length_of_error_type_does_not_produce_an_error")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local l = #this_is_not_defined
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "indexing_error_type_does_not_produce_an_error")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local originalReward = unknown.Parent.Reward:GetChildren()[1]
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "dot_on_error_type_does_not_produce_an_error")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local foo = (true).x
|
|
foo.x = foo.y
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "any_type_propagates")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local foo: any
|
|
local bar = foo:method("argument")
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("any", toString(requireType("bar")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "can_subscript_any")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local foo: any
|
|
local bar = foo[5]
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("any", toString(requireType("bar")));
|
|
}
|
|
|
|
// Not strictly correct: metatables permit overriding this
|
|
TEST_CASE_FIXTURE(Fixture, "can_get_length_of_any")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local foo: any = {}
|
|
local bar = #foo
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ(PrimitiveType::Number, getPrimitiveType(requireType("bar")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "assign_prop_to_table_by_calling_any_yields_any")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local f: any
|
|
local T = {}
|
|
|
|
T.prop = f()
|
|
|
|
return T
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
TableType* ttv = getMutable<TableType>(requireType("T"));
|
|
REQUIRE(ttv);
|
|
REQUIRE(ttv->props.count("prop"));
|
|
|
|
REQUIRE_EQ("any", toString(ttv->props["prop"].type()));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "quantify_any_does_not_bind_to_itself")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local A : any
|
|
function A.B() end
|
|
A:C()
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
TypeId aType = requireType("A");
|
|
CHECK_EQ(aType, builtinTypes->anyType);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "calling_error_type_yields_error")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local a = unknown.Parent.Reward.GetChildren()
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
UnknownSymbol* err = get<UnknownSymbol>(result.errors[0]);
|
|
REQUIRE(err != nullptr);
|
|
|
|
CHECK_EQ("unknown", err->name);
|
|
|
|
if (FFlag::DebugLuauDeferredConstraintResolution)
|
|
CHECK_EQ("any", toString(requireType("a")));
|
|
else
|
|
CHECK_EQ("*error-type*", toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "chain_calling_error_type_yields_error")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local a = Utility.Create "Foo" {}
|
|
)");
|
|
|
|
if (FFlag::DebugLuauDeferredConstraintResolution)
|
|
CHECK_EQ("any", toString(requireType("a")));
|
|
else
|
|
CHECK_EQ("*error-type*", toString(requireType("a")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "replace_every_free_type_when_unifying_a_complex_function_with_any")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local a: any
|
|
local b
|
|
for _, i in pairs(a) do
|
|
b = i
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("any", toString(requireType("b")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "call_to_any_yields_any")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local a: any
|
|
local b = a()
|
|
)");
|
|
|
|
REQUIRE_EQ("any", toString(requireType("b")));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "CheckMethodsOfAny")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x: any = {}
|
|
function x:y(z: number)
|
|
local s: string = z
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "CheckMethodsOfError")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local x = (true).foo
|
|
function x:y(z: number)
|
|
local s: string = z
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERRORS(result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "metatable_of_any_can_be_a_table")
|
|
{
|
|
CheckResult result = check(R"(
|
|
--!strict
|
|
local T: any
|
|
T = {}
|
|
T.__index = T
|
|
function T.new(...)
|
|
local self = {}
|
|
setmetatable(self, T)
|
|
self:construct(...)
|
|
return self
|
|
end
|
|
function T:construct(index)
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "type_error_addition")
|
|
{
|
|
CheckResult result = check(R"(
|
|
--!strict
|
|
local foo = makesandwich()
|
|
local bar = foo.nutrition + 100
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
// We should definitely get this error
|
|
CHECK_EQ("Unknown global 'makesandwich'", toString(result.errors[0]));
|
|
// We get this error if makesandwich() returns a free type
|
|
// CHECK_EQ("Unknown type used in + operation; consider adding a type annotation to 'foo'", toString(result.errors[1]));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "prop_access_on_any_with_other_options")
|
|
{
|
|
CheckResult result = check(R"(
|
|
local function f(thing: any | string)
|
|
local foo = thing.SomeRandomKey
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "union_of_types_regression_test")
|
|
{
|
|
CheckResult result = check(R"(
|
|
--!strict
|
|
local stat
|
|
stat = stat and tonumber(stat) or stat
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(Fixture, "intersection_of_any_can_have_props")
|
|
{
|
|
// *blocked-130* ~ hasProp any & ~(false?), "_status"
|
|
CheckResult result = check(R"(
|
|
function foo(x: any, y)
|
|
if x then
|
|
return x._status
|
|
end
|
|
return y
|
|
end
|
|
)");
|
|
|
|
CHECK("(any, any) -> any" == toString(requireType("foo")));
|
|
}
|
|
|
|
TEST_SUITE_END();
|