From f82e6d79a445d488149b677b846d988b3a2df718 Mon Sep 17 00:00:00 2001 From: Alexander McCord Date: Sun, 26 May 2024 22:24:03 -0700 Subject: [PATCH] Probably should document this magic number. --- EqSat/include/Luau/Language.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/EqSat/include/Luau/Language.h b/EqSat/include/Luau/Language.h index 5247ebab..3053adfb 100644 --- a/EqSat/include/Luau/Language.h +++ b/EqSat/include/Luau/Language.h @@ -26,9 +26,11 @@ std::size_t languageHash(const T& lang) { return LanguageHash{}(lang); } -inline size_t hashCombine(size_t& seed, size_t hash) +inline void hashCombine(size_t& seed, size_t hash) { - return seed ^= hash + 0x9e3779b9 + (seed << 6) + (seed >> 2); + // Golden Ratio constant used for better hash scattering + // See https://softwareengineering.stackexchange.com/a/402543 + seed ^= hash + 0x9e3779b9 + (seed << 6) + (seed >> 2); } #define LUAU_EQSAT_ATOM(name, t) \