From 9472479666528395eaedee4459a5769f17f8cf39 Mon Sep 17 00:00:00 2001
From: "ajeffrey@roblox.com" <ajeffrey@roblox.com>
Date: Tue, 4 Jan 2022 16:03:24 -0600
Subject: [PATCH] Responding to review comments

---
 rfcs/unsealed-table-literals.md | 32 +++++++++++++-------------------
 1 file changed, 13 insertions(+), 19 deletions(-)

diff --git a/rfcs/unsealed-table-literals.md b/rfcs/unsealed-table-literals.md
index da6e7db1..f220f632 100644
--- a/rfcs/unsealed-table-literals.md
+++ b/rfcs/unsealed-table-literals.md
@@ -35,30 +35,16 @@ typechecks, but
 ```
 does not.
 
-This causes problems in examples, for instance
+This causes problems in examples, in particular developers
+may initialize properties but not methods:
 ```lua
-  local t : { p: number, q: string? } = { p = 5, q = "hi" }
-  t = { p = 7 }
-```
-typechecks because we allow subtyping to strip away optional
-properties, so `{ p : number }` is a subtype of
-`{ p : number, q : string? }`. Unfortunately this is not sound,
-since sealed tables support width subtyping:
-```lua
-  local t : { p: number, q: string? } = { p = 5, q = "hi" }
-  local u : { p: number } = { p = 5, q = false }
-  t = u
+  local t = { p = 5 }
+  function t.f() return t.p end
 ```
 
 ## Design
 
-The fix for this source of unsoundness is twofold:
-
-1. make all table literals unsealed, and
-2. only allow stripping optional properties from when the
-   supertype is sealed and the subtype is unsealed.
-
-This RFC is for (1). There is a [separate RFC](unsealed-table-subtyping-strips-optional-properties.md) for (2).
+The proposed change is straightforward: make all table literals unsealed.
 
 ## Drawbacks
 
@@ -67,6 +53,14 @@ Making all table literals unsealed is a conservative change, it only removes typ
 It does encourage developers to add new properties to tables during initialization, which
 may be considered poor style.
 
+It does mean that some spelling mistakes will not be caught, for example
+```lua
+local t = {x = 1, y = 2}
+if foo then
+  t.z = 3 -- is z a typo or intentional 2-vs-3 choice?
+end
+```
+
 ## Alternatives
 
 We could introduce a new table state for unsealed-but-precise