From fb4f3c5c219ebc7c043baa7b990374557899872d Mon Sep 17 00:00:00 2001
From: Benjamin Richner <noreply@example.com>
Date: Tue, 23 Jun 2020 21:17:52 +0200
Subject: [PATCH] Rename `by_name_internal` to `by_name_with_optional_password`
 and `by_index_internal` to `by_index_with_optional_password`

---
 src/read.rs | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/read.rs b/src/read.rs
index 90d90ecf..f89bd311 100644
--- a/src/read.rs
+++ b/src/read.rs
@@ -350,15 +350,15 @@ impl<R: Read + io::Seek> ZipArchive<R> {
         name: &str,
         password: &[u8],
     ) -> ZipResult<ZipFile<'a>> {
-        self.by_name_internal(name, Some(password))
+        self.by_name_with_optional_password(name, Some(password))
     }
 
     /// Search for a file entry by name
     pub fn by_name<'a>(&'a mut self, name: &str) -> ZipResult<ZipFile<'a>> {
-        self.by_name_internal(name, None)
+        self.by_name_with_optional_password(name, None)
     }
 
-    fn by_name_internal<'a>(
+    fn by_name_with_optional_password<'a>(
         &'a mut self,
         name: &str,
         password: Option<&[u8]>,
@@ -369,7 +369,7 @@ impl<R: Read + io::Seek> ZipArchive<R> {
                 return Err(ZipError::FileNotFound);
             }
         };
-        self.by_index_internal(index, password)
+        self.by_index_with_optional_password(index, password)
     }
 
     /// Get a contained file by index, decrypt with given password
@@ -378,15 +378,15 @@ impl<R: Read + io::Seek> ZipArchive<R> {
         file_number: usize,
         password: &[u8],
     ) -> ZipResult<ZipFile<'a>> {
-        self.by_index_internal(file_number, Some(password))
+        self.by_index_with_optional_password(file_number, Some(password))
     }
 
     /// Get a contained file by index
     pub fn by_index<'a>(&'a mut self, file_number: usize) -> ZipResult<ZipFile<'a>> {
-        self.by_index_internal(file_number, None)
+        self.by_index_with_optional_password(file_number, None)
     }
 
-    fn by_index_internal<'a>(
+    fn by_index_with_optional_password<'a>(
         &'a mut self,
         file_number: usize,
         mut password: Option<&[u8]>,