From f86c310fdcfcec8a5a2e530c698f44e0b29f1593 Mon Sep 17 00:00:00 2001
From: Marli Frost <marli@frost.red>
Date: Wed, 19 Aug 2020 13:23:00 +0100
Subject: [PATCH] docs: deprecate `Path` handling methods

These methods were implemented in a non-intuitive way that could easily
lead to bugs. They may be replaced in a future release
---
 src/write.rs | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/write.rs b/src/write.rs
index 6a12816f..92be7c67 100644
--- a/src/write.rs
+++ b/src/write.rs
@@ -290,6 +290,10 @@ impl<W: Write + io::Seek> ZipWriter<W> {
     ///
     /// This function ensures that the '/' path seperator is used. It also ignores all non 'Normal'
     /// Components, such as a starting '/' or '..' and '.'.
+    #[deprecated(
+        since = "0.5.7",
+        note = "by stripping `..`s from the path, the meaning of paths can change. Use `start_file` instead."
+    )]
     pub fn start_file_from_path(
         &mut self,
         path: &std::path::Path,
@@ -327,6 +331,10 @@ impl<W: Write + io::Seek> ZipWriter<W> {
     ///
     /// This function ensures that the '/' path seperator is used. It also ignores all non 'Normal'
     /// Components, such as a starting '/' or '..' and '.'.
+    #[deprecated(
+        since = "0.5.7",
+        note = "by stripping `..`s from the path, the meaning of paths can change. Use `add_directory` instead."
+    )]
     pub fn add_directory_from_path(
         &mut self,
         path: &std::path::Path,