From d5681d9edeaece6e3a7a2318acf0da56e2073184 Mon Sep 17 00:00:00 2001 From: Chris Hennick Date: Sat, 29 Apr 2023 13:16:14 -0700 Subject: [PATCH] Refactor: don't search for src_data twice --- src/write.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/write.rs b/src/write.rs index 313f77d2..89c73f70 100644 --- a/src/write.rs +++ b/src/write.rs @@ -295,11 +295,6 @@ impl ZipWriter { } impl ZipWriter { - fn reader_by_name<'a>(&'a mut self, name: &str) -> ZipResult> { - let data = self.data_by_name(name)?.to_owned(); - find_content(&data, self.inner.get_plain()) - } - /// Adds another copy of a file already in this archive. This will produce a larger but more /// widely-compatible archive compared to [shallow_copy_file]. pub fn deep_copy_file(&mut self, src_name: &str, dest_name: &str) -> ZipResult<()> { @@ -325,7 +320,7 @@ impl ZipWriter { compressed_size, uncompressed_size, }; - let mut reader = BufReader::new(ZipFileReader::Raw(self.reader_by_name(src_name)?)); + let mut reader = BufReader::new(ZipFileReader::Raw(find_content(&data, self.inner.get_plain())?)); let mut copy = Vec::with_capacity(compressed_size as usize); reader.read_to_end(&mut copy)?; drop(reader);