diff --git a/src/write.rs b/src/write.rs index a5f47083..de5d9e23 100644 --- a/src/write.rs +++ b/src/write.rs @@ -475,8 +475,8 @@ impl ZipWriter { self.stats.hasher = Hasher::new(); } if let Some(keys) = options.encrypt_with { - let mut zipwriter = crate::zipcrypto::ZipCryptoWriter { writer: core::mem::replace(&mut self.inner, GenericZipWriter::Closed).unwrap(), buffer: vec![], keys }; - let mut crypto_header = [0u8; 12]; + let mut zipwriter = crate::zipcrypto::ZipCryptoWriter { writer: mem::replace(&mut self.inner, Closed).unwrap(), buffer: vec![], keys }; + let crypto_header = [0u8; 12]; zipwriter.write_all(&crypto_header)?; self.inner = Storer(MaybeEncrypted::Encrypted(zipwriter)); @@ -505,15 +505,9 @@ impl ZipWriter { // Implicitly calling [`ZipWriter::end_extra_data`] for empty files. self.end_extra_data()?; } - let make_plain_writer = match self + let make_plain_writer = self .inner - .prepare_next_writer(CompressionMethod::Stored, None)? { - MaybeEncrypted::Encrypted(writer) => { - let crc32 = self.stats.hasher.clone().finalize(); - self.inner = Storer(MaybeEncrypted::Unencrypted(writer.finish(crc32)?)) - }, - MaybeEncrypted::Unencrypted(writer) => writer - } + .prepare_next_writer(CompressionMethod::Stored, None)?; self.inner.switch_to(make_plain_writer)?; let writer = self.inner.get_plain(); @@ -1036,12 +1030,14 @@ impl Drop for ZipWriter { } } +type SwitchWriterFunction = Box) -> GenericZipWriter>; + impl GenericZipWriter { fn prepare_next_writer( &self, compression: CompressionMethod, compression_level: Option, - ) -> ZipResult) -> GenericZipWriter>> { + ) -> ZipResult> { if let Closed = self { return Err( io::Error::new(io::ErrorKind::BrokenPipe, "ZipWriter was already closed").into(), @@ -1121,7 +1117,7 @@ impl GenericZipWriter { fn switch_to( &mut self, - make_new_self: Box) -> GenericZipWriter>, + make_new_self: SwitchWriterFunction, ) -> ZipResult<()> { let bare = match mem::replace(self, Closed) { Storer(w) => w, diff --git a/src/zipcrypto.rs b/src/zipcrypto.rs index 2e97a647..71af39e3 100644 --- a/src/zipcrypto.rs +++ b/src/zipcrypto.rs @@ -135,12 +135,14 @@ impl ZipCryptoReader { Ok(Some(ZipCryptoReaderValid { reader: self })) } } +#[allow(unused)] pub(crate) struct ZipCryptoWriter { pub(crate) writer: W, pub(crate) buffer: Vec, pub(crate) keys: ZipCryptoKeys, } impl ZipCryptoWriter { + #[allow(unused)] pub(crate) fn finish(mut self, crc32: u32) -> std::io::Result { self.buffer[11] = (crc32 >> 24) as u8; for byte in self.buffer.iter_mut() {