From a29d125ee7a8f84790c6ca14fcdc145d2aecec29 Mon Sep 17 00:00:00 2001
From: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Date: Thu, 9 May 2024 19:50:38 -0700
Subject: [PATCH 1/6] Update pull_request_template.md

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
---
 pull_request_template.md | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/pull_request_template.md b/pull_request_template.md
index b3f11c75..079b0f35 100644
--- a/pull_request_template.md
+++ b/pull_request_template.md
@@ -1,5 +1,16 @@
 <!-- 
-We welcome your pull request, but we have some requirements that a lot of PRs don't meet:
+We welcome your pull request, but because this crate is downloaded about 1.7 million times per month (see https://crates.io/crates/zip),
+and because ZIP file processing has caused security issues in the past (see 
+https://www.cvedetails.com/vulnerability-search.php?f=1&vendor=&product=zip&cweid=&cvssscoremin=&cvssscoremax=&publishdatestart=&publishdateend=&updatedatestart=&updatedateend=&cisaaddstart=&cisaaddend=&cisaduestart=&cisadueend=&page=1
+for the gory details), we have some requirements that help ensure the crate remains secure and panic-free, and that a lot of PRs 
+don't meet.
+
+We don't filter out "ZIP bombs" because extreme compression ratios and shallow file copies have legitimate uses; but
+we expect the tools we provide for checking that extraction is safe, such as the `ZipArchive::decompressed_size` method in
+https://github.com/zip-rs/zip2/blob/master/src/read.rs, to remain reliably effective. We also expect all the crate's methods to
+remain panic-free, so that this crate can be used on servers without creating a denial-of-service vulnerability.
+
+These are our requirements for PRs, in addition to the usual functionality and readability requirements:
 - This codebase sometimes changes rapidly. Please rebase your branch before opening a pull request, and 
   grant @Pr0methean write access to the source branch (so he can fix later conflicts without being subject 
   to the limitations of the web UI) if EITHER of the following apply:
@@ -11,6 +22,10 @@ We welcome your pull request, but we have some requirements that a lot of PRs do
   repo is no longer maintained and will be archived once the pre-existing issues are closed.
 - Your changes must build against the MSRV (see README.md) AND the latest stable Rust version AND the latest nightly Rust version, 
   with `--no-default-features` AND with `--all-features` AND with the default features.
+- PRs must pass `cargo clippy --all-targets` and `cargo fmt --check --all`,
+  with `--no-default-features` AND with `--all-features` AND with the default features.
+  If you need to add a new `#[allow]` attribute, please place a comment on the same line or just above it, explaining what the
+  exception applies to and why it's needed.
 - Commit messages and the PR title must conform to [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) and start 
   with one of the types specified by the [Angular convention](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type).
 - All commits must be signed and display a "Verified" badge; see 

From 431b4cdf2be7c410c3372b793550b7058637ace6 Mon Sep 17 00:00:00 2001
From: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Date: Thu, 9 May 2024 19:59:51 -0700
Subject: [PATCH 2/6] Clarify purpose and checks

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
---
 pull_request_template.md | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/pull_request_template.md b/pull_request_template.md
index 079b0f35..c397864f 100644
--- a/pull_request_template.md
+++ b/pull_request_template.md
@@ -2,8 +2,8 @@
 We welcome your pull request, but because this crate is downloaded about 1.7 million times per month (see https://crates.io/crates/zip),
 and because ZIP file processing has caused security issues in the past (see 
 https://www.cvedetails.com/vulnerability-search.php?f=1&vendor=&product=zip&cweid=&cvssscoremin=&cvssscoremax=&publishdatestart=&publishdateend=&updatedatestart=&updatedateend=&cisaaddstart=&cisaaddend=&cisaduestart=&cisadueend=&page=1
-for the gory details), we have some requirements that help ensure the crate remains secure and panic-free, and that a lot of PRs 
-don't meet.
+for the gory details), we have some requirements that help ensure the crate remains trustworthy and panic-free, and we've seen
+a lot of PRs that don't meet those requirements.
 
 We don't filter out "ZIP bombs" because extreme compression ratios and shallow file copies have legitimate uses; but
 we expect the tools we provide for checking that extraction is safe, such as the `ZipArchive::decompressed_size` method in
@@ -20,12 +20,16 @@ These are our requirements for PRs, in addition to the usual functionality and r
     conflicts, but this is best-effort.
 - Please make sure the repo your PR targets is `zip-rs/zip2` and not `zip-rs/zip-old`. The latter
   repo is no longer maintained and will be archived once the pre-existing issues are closed.
-- Your changes must build against the MSRV (see README.md) AND the latest stable Rust version AND the latest nightly Rust version, 
-  with `--no-default-features` AND with `--all-features` AND with the default features.
-- PRs must pass `cargo clippy --all-targets` and `cargo fmt --check --all`,
-  with `--no-default-features` AND with `--all-features` AND with the default features.
-  If you need to add a new `#[allow]` attribute, please place a comment on the same line or just above it, explaining what the
-  exception applies to and why it's needed.
+- Your changes must build against the MSRV (see README.md) AND the latest stable Rust version AND the latest nightly Rust version.
+- PRs must pass all the checks specified in `.github/workflows/ci.yaml`, which include:
+  - Unit tests, run with `--no-default-features` AND with `--all-features` AND with the default features, each run
+    against the MSRV (see README.md) AND the latest stable Rust version AND the latest nightly Rust version, on Windows, MacOS 
+    AND Ubuntu (yes, that's a 3-dimensional matrix).
+  - `cargo clippy --all-targets` and `cargo doc --no-deps` must pass with `--no-default-features` AND with `--all-features` 
+    AND with the default features.
+  - `cargo fmt --check --all` must pass.
+- If the above checks force you to add a new `#[allow]` attribute, please place a comment on the same line or just above it, 
+  explaining what the exception applies to and why it's needed.
 - Commit messages and the PR title must conform to [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) and start 
   with one of the types specified by the [Angular convention](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type).
 - All commits must be signed and display a "Verified" badge; see 

From 8a734f9daccbf3af8f6d305c9ae03033d4c0b52b Mon Sep 17 00:00:00 2001
From: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Date: Thu, 9 May 2024 20:01:40 -0700
Subject: [PATCH 3/6] Rephrase

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
---
 pull_request_template.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pull_request_template.md b/pull_request_template.md
index c397864f..c07ea483 100644
--- a/pull_request_template.md
+++ b/pull_request_template.md
@@ -2,7 +2,7 @@
 We welcome your pull request, but because this crate is downloaded about 1.7 million times per month (see https://crates.io/crates/zip),
 and because ZIP file processing has caused security issues in the past (see 
 https://www.cvedetails.com/vulnerability-search.php?f=1&vendor=&product=zip&cweid=&cvssscoremin=&cvssscoremax=&publishdatestart=&publishdateend=&updatedatestart=&updatedateend=&cisaaddstart=&cisaaddend=&cisaduestart=&cisadueend=&page=1
-for the gory details), we have some requirements that help ensure the crate remains trustworthy and panic-free, and we've seen
+for the gory details), we have some requirements that help ensure the crate earns and keeps developers' trust, and we've seen
 a lot of PRs that don't meet those requirements.
 
 We don't filter out "ZIP bombs" because extreme compression ratios and shallow file copies have legitimate uses; but

From aea27a76424ed1353efceeecee390f8e53ff0053 Mon Sep 17 00:00:00 2001
From: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Date: Thu, 9 May 2024 20:06:54 -0700
Subject: [PATCH 4/6] Rephrase "trust" sentence and mention Amazon LP

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
---
 pull_request_template.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pull_request_template.md b/pull_request_template.md
index c07ea483..12772b49 100644
--- a/pull_request_template.md
+++ b/pull_request_template.md
@@ -2,8 +2,9 @@
 We welcome your pull request, but because this crate is downloaded about 1.7 million times per month (see https://crates.io/crates/zip),
 and because ZIP file processing has caused security issues in the past (see 
 https://www.cvedetails.com/vulnerability-search.php?f=1&vendor=&product=zip&cweid=&cvssscoremin=&cvssscoremax=&publishdatestart=&publishdateend=&updatedatestart=&updatedateend=&cisaaddstart=&cisaaddend=&cisaduestart=&cisadueend=&page=1
-for the gory details), we have some requirements that help ensure the crate earns and keeps developers' trust, and we've seen
-a lot of PRs that don't meet those requirements.
+for the gory details), we have some requirements that help ensure we continuously earn developers' and their clients'
+trust (see also the "Earn Trust" principle at https://www.amazon.jobs/content/en/our-workplace/leadership-principles),
+and we've received a lot of PRs that didn't initially meet those requirements.
 
 We don't filter out "ZIP bombs" because extreme compression ratios and shallow file copies have legitimate uses; but
 we expect the tools we provide for checking that extraction is safe, such as the `ZipArchive::decompressed_size` method in

From 73e44dbedb8515fe087cefab14995cac37c468d5 Mon Sep 17 00:00:00 2001
From: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Date: Thu, 9 May 2024 20:15:53 -0700
Subject: [PATCH 5/6] Rephrase (we->I; relation to Amazon LPs)

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
---
 pull_request_template.md | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/pull_request_template.md b/pull_request_template.md
index 12772b49..7d038973 100644
--- a/pull_request_template.md
+++ b/pull_request_template.md
@@ -3,24 +3,26 @@ We welcome your pull request, but because this crate is downloaded about 1.7 mil
 and because ZIP file processing has caused security issues in the past (see 
 https://www.cvedetails.com/vulnerability-search.php?f=1&vendor=&product=zip&cweid=&cvssscoremin=&cvssscoremax=&publishdatestart=&publishdateend=&updatedatestart=&updatedateend=&cisaaddstart=&cisaaddend=&cisaduestart=&cisadueend=&page=1
 for the gory details), we have some requirements that help ensure we continuously earn developers' and their clients'
-trust (see also the "Earn Trust" principle at https://www.amazon.jobs/content/en/our-workplace/leadership-principles),
-and we've received a lot of PRs that didn't initially meet those requirements.
+trust. I (@Pr0methean) am an Amazonian, and although I maintain this crate in a personal capacity (except when fellow Amazonians 
+express new requirements), I still strive to uphold Amazon's Leadership Principles, especially "Earn Trust" (see
+https://www.amazon.jobs/content/en/our-workplace/leadership-principles.) But I've received a lot of PRs that didn't initially meet
+the requirements I derived from that LP.
 
-We don't filter out "ZIP bombs" because extreme compression ratios and shallow file copies have legitimate uses; but
-we expect the tools we provide for checking that extraction is safe, such as the `ZipArchive::decompressed_size` method in
-https://github.com/zip-rs/zip2/blob/master/src/read.rs, to remain reliably effective. We also expect all the crate's methods to
+This crate doesn't filter out "ZIP bombs" because extreme compression ratios and shallow file copies have legitimate uses; but
+I expect the tools the crate provides for checking that extraction is safe, such as the `ZipArchive::decompressed_size` method in
+https://github.com/zip-rs/zip2/blob/master/src/read.rs, to remain reliably effective. I also expect all the crate's methods to
 remain panic-free, so that this crate can be used on servers without creating a denial-of-service vulnerability.
 
 These are our requirements for PRs, in addition to the usual functionality and readability requirements:
 - This codebase sometimes changes rapidly. Please rebase your branch before opening a pull request, and 
-  grant @Pr0methean write access to the source branch (so he can fix later conflicts without being subject 
+  grant @Pr0methean write access to the source branch (so I can fix later conflicts without being subject 
   to the limitations of the web UI) if EITHER of the following apply:
   - It has been at least 24 hours since you forked the repo or previously rebased the branch; or
   - 5 or more pull requests are already open at https://github.com/zip-rs/zip2/pulls. PRs are merged in the order they become
-    eligible (reviewed, passing CI tests, and no conflicts with the base branch). @Pr0methean will attempt to fix merge
+    eligible (reviewed, passing CI tests, and no conflicts with the base branch). I will attempt to fix merge
     conflicts, but this is best-effort.
-- Please make sure the repo your PR targets is `zip-rs/zip2` and not `zip-rs/zip-old`. The latter
-  repo is no longer maintained and will be archived once the pre-existing issues are closed.
+- Please make sure your PR's target repo is `zip-rs/zip2` and not `zip-rs/zip-old`. The latter
+  repo is no longer maintained, and I will archive it after closing the pre-existing issues.
 - Your changes must build against the MSRV (see README.md) AND the latest stable Rust version AND the latest nightly Rust version.
 - PRs must pass all the checks specified in `.github/workflows/ci.yaml`, which include:
   - Unit tests, run with `--no-default-features` AND with `--all-features` AND with the default features, each run
@@ -48,4 +50,6 @@ These are our requirements for PRs, in addition to the usual functionality and r
      https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
   6. Squash your PR into one commit or run `git commit --amend --no-edit`, because enabling commit signing isn't retroactive
      even for unpushed commits.
+
+Thanks in advance for submitting a bug fix or proposed feature that meets these requirements!
 -->

From 6b0c934e097e99bf366cf98b55daefdbe0fd53ff Mon Sep 17 00:00:00 2001
From: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Date: Thu, 9 May 2024 20:17:10 -0700
Subject: [PATCH 6/6] doc: nit: punctuation

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
---
 pull_request_template.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pull_request_template.md b/pull_request_template.md
index 7d038973..dcd7ffdf 100644
--- a/pull_request_template.md
+++ b/pull_request_template.md
@@ -5,7 +5,7 @@ https://www.cvedetails.com/vulnerability-search.php?f=1&vendor=&product=zip&cwei
 for the gory details), we have some requirements that help ensure we continuously earn developers' and their clients'
 trust. I (@Pr0methean) am an Amazonian, and although I maintain this crate in a personal capacity (except when fellow Amazonians 
 express new requirements), I still strive to uphold Amazon's Leadership Principles, especially "Earn Trust" (see
-https://www.amazon.jobs/content/en/our-workplace/leadership-principles.) But I've received a lot of PRs that didn't initially meet
+https://www.amazon.jobs/content/en/our-workplace/leadership-principles). But I've received a lot of PRs that didn't initially meet
 the requirements I derived from that LP.
 
 This crate doesn't filter out "ZIP bombs" because extreme compression ratios and shallow file copies have legitimate uses; but