From 822a734ae4522fee4eaeeebd7a7668eb49c3e1db Mon Sep 17 00:00:00 2001 From: Nick Babcock Date: Sat, 6 May 2023 07:33:59 -0500 Subject: [PATCH] Support zstd in Wasm by disabling default features Use case: creating zstd zips in Wasm Currently it is not possible to create zstd zips in Wasm due to the default `zdict_builder` needing additional code that will cause compilation to fail for wasm32-unknown-unknown: https://github.com/gyscos/zstd-rs/issues/210 Since the zip crate's zstd implementation does not use anything from the `zdict_builder` feature, I've disabled it. I've gone a step further and disabled the other features as well (`arrays` and `legacy`), as they are either unused (`arrays`) or a legacy format from 7 years ago that predates when the zip format supported zstd. So far this patch has been working well for the Wasm application, and figured I should upstream it. --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index 83df6493..989bb20b 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -22,7 +22,7 @@ hmac = { version = "0.12.1", optional = true, features = ["reset"] } pbkdf2 = {version = "0.12.1", optional = true } sha1 = {version = "0.10.5", optional = true } time = { version = "0.3.20", optional = true, default-features = false, features = ["std"] } -zstd = { version = "0.12.3", optional = true } +zstd = { version = "0.12.3", optional = true, default-features = false } [target.'cfg(any(all(target_arch = "arm", target_pointer_width = "32"), target_arch = "mips", target_arch = "powerpc"))'.dependencies] crossbeam-utils = "0.8.15"