From 511e07abb5cf7303c41a30f6bbe402baeff8d1d3 Mon Sep 17 00:00:00 2001 From: ok-nick Date: Wed, 20 Sep 2023 00:21:27 -0400 Subject: [PATCH 1/5] fix: test with $HOME instead of ~ --- action.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/action.yml b/action.yml index 68f25ed..6d326f1 100644 --- a/action.yml +++ b/action.yml @@ -58,12 +58,12 @@ runs: - name: Set environment variable if: runner.os != 'Windows' - run: echo "~/.aftman/bin" >> $GITHUB_PATH + run: echo "$HOME/.aftman/bin" >> $GITHUB_PATH shell: bash - name: Create auth file run: | - cat > ~/.aftman/auth.toml << EOF + cat > $HOME/.aftman/auth.toml << EOF github = "${{ inputs.token }}" EOF shell: bash @@ -73,9 +73,8 @@ runs: uses: actions/cache@v3 with: path: | - ~/.aftman/bin - ~/.aftman/tool-storage - # TODO: also hash ~/.aftman/aftman.toml + $HOME/.aftman/bin + $HOME/.aftman/tool-storage key: ${{ runner.os }}-aftman-${{hashFiles(format('{0}/{1}', inputs.path, 'aftman.toml'))}} - name: Install tools From 5a154265633b89537fda60cce2cfab259cca4adb Mon Sep 17 00:00:00 2001 From: ok-nick Date: Wed, 20 Sep 2023 13:07:24 -0400 Subject: [PATCH 2/5] refactor: disable caching by default --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 6d326f1..ec9198d 100644 --- a/action.yml +++ b/action.yml @@ -12,7 +12,7 @@ inputs: required: false cache: description: "Whether to enable caching" - default: "true" + default: "false" required: false token: description: "GitHub token via `github.token`" From 3aa1ee04795dad7ef266de81833c7f500ab01d50 Mon Sep 17 00:00:00 2001 From: ok-nick Date: Wed, 20 Sep 2023 13:08:44 -0400 Subject: [PATCH 3/5] ci: set cache parameter explicitly --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 86d0372..deed153 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,6 +15,8 @@ defaults: jobs: test-cache: uses: ./.github/workflows/env.yml + with: + cache: "true" test-no-cache: uses: ./.github/workflows/env.yml with: From e3fb06e842969c879773a4f9314eeb9e8a119492 Mon Sep 17 00:00:00 2001 From: ok-nick Date: Wed, 20 Sep 2023 13:12:20 -0400 Subject: [PATCH 4/5] fix: use ~ for cache path --- action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/action.yml b/action.yml index ec9198d..6443578 100644 --- a/action.yml +++ b/action.yml @@ -73,8 +73,8 @@ runs: uses: actions/cache@v3 with: path: | - $HOME/.aftman/bin - $HOME/.aftman/tool-storage + ~/.aftman/bin + ~/.aftman/tool-storage key: ${{ runner.os }}-aftman-${{hashFiles(format('{0}/{1}', inputs.path, 'aftman.toml'))}} - name: Install tools From fca3f1ddcac28ced9d6e468cc0c0b17a325650f3 Mon Sep 17 00:00:00 2001 From: ok-nick Date: Wed, 20 Sep 2023 13:21:14 -0400 Subject: [PATCH 5/5] docs: add unreleased stuff --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 909ea59..a3cc80f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +## Changed +- Disable caching by default #15 + +## Fixed +- Issue causing executables to not be found #14 ## [0.4.1] - 2023-09-18 ## Fixed