DevComp/lune-packaging
1
0
Fork 0
mirror of https://github.com/CompeyDev/lune-packaging.git synced 2025-01-09 20:29:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix integer attributes

Browse source
This commit is contained in:
Filip Tibell 2023-03-26 12:43:01 +02:00
parent 4cb260c7dd
commit 7c9a1bef86
No known key found for this signature in database
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed instances with attributes not saving if they container integer attributes
- Fixed attributes not being set properly if the instance has an empty attributes property - Fixed attributes not being set properly if the instance has an empty attributes property
- Fixed error messages for reading & writing roblox files not containing the full error message - Fixed error messages for reading & writing roblox files not containing the full error message
- Fixed crash when trying to access an instance reference property that points to a destroyed instance - Fixed crash when trying to access an instance reference property that points to a destroyed instance

6
packages/lib-roblox/src/instance/mod.rs
View file

@ -516,6 +516,12 @@ impl Instance {
let inst = dom let inst = dom
.get_by_ref_mut(self.dom_ref) .get_by_ref_mut(self.dom_ref)
.expect("Failed to find instance in document"); .expect("Failed to find instance in document");
// NOTE: Attributes do not support integers, only floats
let value = match value {
DomValue::Int32(i) => DomValue::Float32(i as f32),
DomValue::Int64(i) => DomValue::Float64(i as f64),
value => value,
};
if let Some(DomValue::Attributes(attributes)) = if let Some(DomValue::Attributes(attributes)) =
inst.properties.get_mut(PROPERTY_NAME_ATTRIBUTES) inst.properties.get_mut(PROPERTY_NAME_ATTRIBUTES)
{ {