More typedef improvements for roblox builtin

docs/typedefs/Roblox.luau

@@ -2,7 +2,8 @@ type InstanceProperties = {
 	Parent: Instance?,
 	ClassName: string,
 	Name: string,
-	-- FIXME: This breaks intellisense, but we need some way to access instance properties...
+	-- FIXME: This breaks intellisense, but we need some way to access
+	-- instance properties without casting the entire instance to any...
 	-- [string]: any,
 }
 
@@ -218,4 +219,8 @@ return {
 	getAuthCookie = function(raw: boolean?): string?
 		return nil :: any
 	end,
+	-- TODO: Make typedefs for all of the datatypes as well...
+	Instance = (nil :: any) :: {
+		new: ((className: "DataModel") -> DataModel) & ((className: string) -> Instance),
+	},
 }

tests/roblox/files/deserializeModel.luau

@@ -1,5 +1,5 @@
 local fs = require("@lune/fs")
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 
 local modelDirs = {}
 for _, dirName in fs.readDir("tests/roblox/rbx-test-files/places") do

tests/roblox/files/deserializePlace.luau

@@ -1,5 +1,5 @@
 local fs = require("@lune/fs")
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 
 local placeDirs = {}
 for _, dirName in fs.readDir("tests/roblox/rbx-test-files/places") do

tests/roblox/files/serializeModel.luau

@@ -1,5 +1,5 @@
 local fs = require("@lune/fs")
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local instances = {

tests/roblox/files/serializePlace.luau

@@ -1,5 +1,5 @@
 local fs = require("@lune/fs")
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local game = Instance.new("DataModel")

tests/roblox/instance/classes/DataModel.luau

@@ -1,18 +1,19 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local game = Instance.new("DataModel")
 
 -- Workspace should always exist as a "Workspace" property, or be created when accessed
 
-assert(game.Workspace ~= nil)
+local workspace = (game :: any).Workspace
-assert(game.Workspace:IsA("Workspace"))
+assert(workspace ~= nil)
-assert(game.Workspace == game:FindFirstChildOfClass("Workspace"))
+assert(workspace:IsA("Workspace"))
+assert(workspace == game:FindFirstChildOfClass("Workspace"))
 
 -- GetService and FindService should work, GetService should create services that don't exist
 
 assert(game:FindService("CSGDictionaryService") == nil)
-assert(game:GetService("CSGDictionaryService") ~= nil)
+assert(game:GetService("CSGDictionaryService"))
 assert(game:FindService("CSGDictionaryService") ~= nil)
 
 -- Service names should be strict and not allow weird characters or substrings

tests/roblox/instance/classes/Workspace.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local game = Instance.new("DataModel")
@@ -6,12 +6,14 @@ local workspace = game:GetService("Workspace")
 
 -- Terrain should always exist as a "Terrain" property, or be created when accessed
 
-assert(workspace.Terrain ~= nil)
+local terrain = (workspace :: any).Terrain
-assert(workspace.Terrain:IsA("Terrain"))
+assert(terrain ~= nil)
-assert(workspace.Terrain == workspace:FindFirstChildOfClass("Terrain"))
+assert(terrain:IsA("Terrain"))
+assert(terrain == workspace:FindFirstChildOfClass("Terrain"))
 
 -- Camera should always exist as a "CurrentCamera" property, or be created when accessed
 
-assert(workspace.CurrentCamera ~= nil)
+local camera = (workspace :: any).CurrentCamera
-assert(workspace.CurrentCamera:IsA("Camera"))
+assert(camera ~= nil)
-assert(workspace.CurrentCamera == workspace:FindFirstChildOfClass("Camera"))
+assert(camera:IsA("Camera"))
+assert(camera == workspace:FindFirstChildOfClass("Camera"))

tests/roblox/instance/methods/ClearAllChildren.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Model")

tests/roblox/instance/methods/Clone.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Model")
@@ -7,9 +7,9 @@ local objValue1 = Instance.new("ObjectValue")
 local objValue2 = Instance.new("ObjectValue")
 
 objValue1.Name = "ObjectValue1"
-objValue2.Name = "ObjectValue2"
+objValue2.Name = "ObjectValue2";
-objValue1.Value = root
+(objValue1 :: any).Value = root;
-objValue2.Value = child
+(objValue2 :: any).Value = child
 objValue1.Parent = child
 objValue2.Parent = child
 child.Parent = root

tests/roblox/instance/methods/Destroy.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/methods/FindFirstAncestor.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/methods/FindFirstAncestorOfClass.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/methods/FindFirstAncestorWhichIsA.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/methods/FindFirstChild.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/methods/FindFirstChildOfClass.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/methods/FindFirstChildWhichIsA.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/methods/GetChildren.luau

@@ -1,5 +1,5 @@
 local fs = require("@lune/fs")
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local modelFile = fs.readFile("tests/roblox/rbx-test-files/models/three-nested-folders/binary.rbxm")

tests/roblox/instance/methods/GetDescendants.luau

@@ -1,5 +1,5 @@
 local fs = require("@lune/fs")
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local modelFile = fs.readFile("tests/roblox/rbx-test-files/models/three-nested-folders/binary.rbxm")

tests/roblox/instance/methods/GetFullName.luau

@@ -1,11 +1,13 @@
 local fs = require("@lune/fs")
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 
 local modelFile = fs.readFile("tests/roblox/rbx-test-files/models/three-nested-folders/binary.rbxm")
 local model = roblox.deserializeModel(modelFile)[1]
 
 local child = model:FindFirstChild("Parent")
+assert(child ~= nil)
 local descendant = child:FindFirstChild("Child")
+assert(descendant ~= nil)
 
 assert(descendant:GetFullName() == "Grandparent.Parent.Child")
 assert(child:GetFullName() == "Grandparent.Parent")

tests/roblox/instance/methods/IsA.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local part = Instance.new("Part")

tests/roblox/instance/methods/IsAncestorOf.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/methods/IsDescendantOf.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local root = Instance.new("Folder")

tests/roblox/instance/new.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 -- Should not allow creating unknown classes
@@ -33,7 +33,7 @@ assert(model.Parent == nil)
 -- Parenting and indexing should work
 model.Parent = folder
 assert(model.Parent == folder)
-assert(folder.Model == model)
+assert((folder :: any).Model == model)
 
 -- Parenting to nil should work
 model.Parent = nil
@@ -43,6 +43,6 @@ assert(model.Parent == nil)
 model.Name = "MyCoolModel"
 assert(model.Name == "MyCoolModel")
 assert(not pcall(function()
-	model.Name = nil
+	model.Name = nil :: any
 end))
 assert(model.Name == "MyCoolModel")

tests/roblox/instance/tags.luau

@@ -1,4 +1,4 @@
-local roblox = require("@lune/roblox") :: any
+local roblox = require("@lune/roblox")
 local Instance = roblox.Instance
 
 local model = Instance.new("Model")