DevComp/lune-packaging
1
0
Fork 0
mirror of https://github.com/CompeyDev/lune-packaging.git synced 2025-01-09 12:19:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix process exit behavior

Browse source
This commit is contained in:
Filip Tibell 2023-01-28 11:16:13 -05:00
parent b414174ee6
commit 589c52f769
No known key found for this signature in database
2 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/lib/globals/process.rs
View file

@ -4,11 +4,12 @@ use std::{
path::PathBuf,
process::{Command, Stdio},
sync::Weak,
time::Duration,
};
use mlua::prelude::*;
use os_str_bytes::RawOsString;
use smol::channel::Sender;
use smol::{channel::Sender, Timer};
use crate::{
utils::{process::pipe_and_inherit_child_process_stdio, table::TableBuilder},
@ -120,10 +121,15 @@ async fn process_exit(lua: &Lua, exit_code: Option<u8>) -> LuaResult<()> {
.unwrap()
.upgrade()
.unwrap();
// Send an exit signal to the main thread, which
// will try to exit safely and as soon as possible
sender
.send(LuneMessage::Exit(exit_code.unwrap_or(0)))
.await
.map_err(LuaError::external)?;
// Make sure to block the rest of this thread indefinitely since
// the main thread may not register the exit signal right away
Timer::after(Duration::MAX).await;
Ok(())
}

15
src/tests/process/exit.luau
View file

@ -1,3 +1,14 @@
process.exit(0)
local function assert(condition, err)
if not condition then
console.error(err)
process.exit(0)
end
end
error("Process should have exited successfully")
local path = process.cwd .. "asdfghjkl"
assert(fs.isDir(path), "Process should exit")
assert(fs.isDir(path), "Process should exit")
assert(fs.isDir(path), "Process should exit")
error("Process should have exited...")