DevComp/fxtwitter-docker
1
0
Fork 0
mirror of https://github.com/CompeyDev/fxtwitter-docker.git synced 2025-04-05 10:30:55 +01:00
Code Issues Projects Releases Packages Wiki Activity

Treat responses as unknown in fetch code

Browse source
This commit is contained in:
dangered wolf 2022-09-16 20:22:45 -04:00
parent 94d1f6d56a
commit f774b4793a
No known key found for this signature in database
GPG key ID: 41E4D37680ED8B58
1 changed files with 23 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
src/fetch.ts
View file

@ -5,8 +5,8 @@ const API_ATTEMPTS = 16;
export const twitterFetch = async ( export const twitterFetch = async (
url: string, url: string,
event: FetchEvent, event: FetchEvent,
validateFunction: (response: any) => boolean, validateFunction: (response: unknown) => boolean
): Promise<TimelineBlobPartial> => { ): Promise<unknown> => {
let apiAttempts = 0; let apiAttempts = 0;
let newTokenGenerated = false; let newTokenGenerated = false;
@ -110,17 +110,14 @@ export const twitterFetch = async (
/* We pretend to be the Twitter Web App as closely as possible, /* We pretend to be the Twitter Web App as closely as possible,
so we use twitter.com/i/api/2 instead of api.twitter.com/2. so we use twitter.com/i/api/2 instead of api.twitter.com/2.
We probably don't have to do this at all. But hey, better to be consistent with Twitter Web App. */ We probably don't have to do this at all. But hey, better to be consistent with Twitter Web App. */
let response: any; let response: unknown;
let apiRequest; let apiRequest;
try { try {
apiRequest = await fetch( apiRequest = await fetch(url, {
url, method: 'GET',
{ headers: headers
method: 'GET', });
headers: headers
}
);
response = await apiRequest.json(); response = await apiRequest.json();
} catch (e: unknown) { } catch (e: unknown) {
/* We'll usually only hit this if we get an invalid response from Twitter. /* We'll usually only hit this if we get an invalid response from Twitter.
@ -163,24 +160,31 @@ export const twitterFetch = async (
console.log('Caching guest token'); console.log('Caching guest token');
event.waitUntil(cache.put(guestTokenRequestCacheDummy.clone(), cachingResponse)); event.waitUntil(cache.put(guestTokenRequestCacheDummy.clone(), cachingResponse));
} }
// @ts-expect-error - We'll pin the guest token to whatever response we have
response.guestToken = guestToken; response.guestToken = guestToken;
return response; return response;
} }
console.log('Twitter has repeatedly denied our requests, so we give up now'); console.log('Twitter has repeatedly denied our requests, so we give up now');
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error - This is only returned if we completely failed to fetch the response
return {}; return {};
}; };
export const fetchUsingGuest = async ( export const fetchConversation = async (
status: string, status: string,
event: FetchEvent event: FetchEvent
): Promise<TimelineBlobPartial> => { ): Promise<TimelineBlobPartial> => {
return await twitterFetch(`${Constants.TWITTER_ROOT}/i/api/2/timeline/conversation/${status}.json?${Constants.GUEST_FETCH_PARAMETERS}`, event, (conversation: TimelineBlobPartial) => { return (await twitterFetch(
return !(typeof conversation.globalObjects === 'undefined' && `${Constants.TWITTER_ROOT}/i/api/2/timeline/conversation/${status}.json?${Constants.GUEST_FETCH_PARAMETERS}`,
(typeof conversation.errors === 'undefined' || event,
conversation.errors?.[0]?.code === 239)); (_conversation: unknown) => {
}); const conversation = _conversation as TimelineBlobPartial;
} return !(
typeof conversation.globalObjects === 'undefined' &&
(typeof conversation.errors === 'undefined' ||
conversation.errors?.[0]?.code === 239)
);
}
)) as TimelineBlobPartial;
};