DevComp/fxtwitter-docker
1
0
Fork 0
mirror of https://github.com/CompeyDev/fxtwitter-docker.git synced 2025-04-05 10:30:55 +01:00
Code Issues Projects Releases Packages Wiki Activity

Decouple token fetching from conversation API

Browse source
This commit is contained in:
dangered wolf 2022-09-16 20:18:08 -04:00
parent 935382ab38
commit f67d834876
No known key found for this signature in database
GPG key ID: 41E4D37680ED8B58
1 changed files with 24 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
src/fetch.ts
View file

@ -2,9 +2,10 @@ import { Constants } from './constants';
const API_ATTEMPTS = 16; const API_ATTEMPTS = 16;
export const fetchUsingGuest = async ( export const twitterFetch = async (
status: string, url: string,
event: FetchEvent event: FetchEvent,
validateFunction: (response: any) => boolean,
): Promise<TimelineBlobPartial> => { ): Promise<TimelineBlobPartial> => {
let apiAttempts = 0; let apiAttempts = 0;
let newTokenGenerated = false; let newTokenGenerated = false;
@ -109,22 +110,22 @@ export const fetchUsingGuest = async (
/* We pretend to be the Twitter Web App as closely as possible, /* We pretend to be the Twitter Web App as closely as possible,
so we use twitter.com/i/api/2 instead of api.twitter.com/2. so we use twitter.com/i/api/2 instead of api.twitter.com/2.
We probably don't have to do this at all. But hey, better to be consistent with Twitter Web App. */ We probably don't have to do this at all. But hey, better to be consistent with Twitter Web App. */
let conversation: TimelineBlobPartial; let response: any;
let apiRequest; let apiRequest;
try { try {
apiRequest = await fetch( apiRequest = await fetch(
`${Constants.TWITTER_ROOT}/i/api/2/timeline/conversation/${status}.json?${Constants.GUEST_FETCH_PARAMETERS}`, url,
{ {
method: 'GET', method: 'GET',
headers: headers headers: headers
} }
); );
conversation = await apiRequest.json(); response = await apiRequest.json();
} catch (e: unknown) { } catch (e: unknown) {
/* We'll usually only hit this if we get an invalid response from Twitter. /* We'll usually only hit this if we get an invalid response from Twitter.
It's uncommon, but it happens */ It's uncommon, but it happens */
console.error('Unknown error while fetching conversation from API'); console.error('Unknown error while fetching from API');
event && event &&
event.waitUntil( event.waitUntil(
cache.delete(guestTokenRequestCacheDummy.clone(), { ignoreMethod: true }) cache.delete(guestTokenRequestCacheDummy.clone(), { ignoreMethod: true })
@ -146,12 +147,8 @@ export const fetchUsingGuest = async (
); );
} }
if ( if (!validateFunction(response)) {
typeof conversation.globalObjects === 'undefined' && console.log('Failed to fetch response, got', response);
(typeof conversation.errors === 'undefined' ||
conversation.errors?.[0]?.code === 239) /* Error 239 = Bad guest token */
) {
console.log('Failed to fetch conversation, got', conversation);
newTokenGenerated = true; newTokenGenerated = true;
continue; continue;
} }
@ -166,13 +163,24 @@ export const fetchUsingGuest = async (
console.log('Caching guest token'); console.log('Caching guest token');
event.waitUntil(cache.put(guestTokenRequestCacheDummy.clone(), cachingResponse)); event.waitUntil(cache.put(guestTokenRequestCacheDummy.clone(), cachingResponse));
} }
conversation.guestToken = guestToken; response.guestToken = guestToken;
return conversation; return response;
} }
console.log('Twitter has repeatedly denied our requests, so we give up now'); console.log('Twitter has repeatedly denied our requests, so we give up now');
// eslint-disable-next-line @typescript-eslint/ban-ts-comment // eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error - This is only returned if we completely failed to fetch the conversation // @ts-expect-error - This is only returned if we completely failed to fetch the response
return {}; return {};
}; };
export const fetchUsingGuest = async (
status: string,
event: FetchEvent
): Promise<TimelineBlobPartial> => {
return await twitterFetch(`${Constants.TWITTER_ROOT}/i/api/2/timeline/conversation/${status}.json?${Constants.GUEST_FETCH_PARAMETERS}`, event, (conversation: TimelineBlobPartial) => {
return !(typeof conversation.globalObjects === 'undefined' &&
(typeof conversation.errors === 'undefined' ||
conversation.errors?.[0]?.code === 239));
});
}