From e16bd916f3ef5cb3d0a1974fa06dc267cb038488 Mon Sep 17 00:00:00 2001
From: dangered wolf <d@ngeredwolf.me>
Date: Sun, 15 Oct 2023 14:36:53 -0400
Subject: [PATCH] Use consistent `id` parameter

---
 src/api/status.ts | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/api/status.ts b/src/api/status.ts
index 008aca8..76a6e8c 100644
--- a/src/api/status.ts
+++ b/src/api/status.ts
@@ -44,9 +44,12 @@ const populateTweetProperties = async (
   const graphQLUser = tweet.core.user_results.result;
   const apiUser = convertToApiUser(graphQLUser);
 
+  /* Sometimes, `rest_id` is undefined for some reason. Inconsistent behavior. See: https://github.com/FixTweet/FixTweet/issues/416 */
+  const id = tweet.rest_id ?? tweet.legacy.id_str;
+
   /* Populating a lot of the basics */
-  apiTweet.url = `${Constants.TWITTER_ROOT}/${apiUser.screen_name}/status/${tweet.rest_id ?? tweet.legacy.id_str}`;
-  apiTweet.id = tweet.rest_id ?? tweet.legacy.id_str;
+  apiTweet.url = `${Constants.TWITTER_ROOT}/${apiUser.screen_name}/status/${id}`;
+  apiTweet.id = id;
   apiTweet.text = unescapeText(linkFixer(tweet.legacy.entities?.urls, tweet.legacy.full_text || ''));
   apiTweet.author = {
     id: apiUser.id,
@@ -145,7 +148,7 @@ const populateTweetProperties = async (
 
   /* Handle photos and mosaic if available */
   if ((apiTweet?.media?.photos?.length || 0) > 1) {
-    const mosaic = await handleMosaic(apiTweet.media?.photos || [], tweet.rest_id);
+    const mosaic = await handleMosaic(apiTweet.media?.photos || [], id);
     if (typeof apiTweet.media !== 'undefined' && mosaic !== null) {
       apiTweet.media.mosaic = mosaic;
     }